All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	Hugh Dickins <hugh@veritas.com>,
	"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: [PATCH 2/2] corruption check: run the corruption checks from a work queue
Date: Mon, 22 Sep 2008 23:03:39 -0700	[thread overview]
Message-ID: <48D886BB.80804@goop.org> (raw)
In-Reply-To: <20080922195839.5bf7bd62@infradead.org>

Arjan van de Ven wrote:
> -void start_periodic_check_for_corruption(void)
> +
> +
> +int start_periodic_check_for_corruption(void)
>   
Couldn't this be static now?

>  {
>  	if (!memory_corruption_check || corruption_check_period == 0)
> -		return;
> +		return 0;
>  
>  	printk(KERN_INFO "Scanning for low memory corruption every %d seconds\n",
>  	       corruption_check_period);
>  
>  	init_timer(&periodic_check_timer);
>  	periodic_check_timer.function = &periodic_check_for_corruption;
> -	periodic_check_for_corruption(0);
> +	mod_timer(&periodic_check_timer,
> +			round_jiffies(jiffies + corruption_check_period*HZ));
> +
> +	return 0;
>  }
> +
> +module_init(start_periodic_check_for_corruption);

    J

  reply	other threads:[~2008-09-23  6:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23  2:58 [PATCH 1/2] corruption check: move the corruption checks into their own file Arjan van de Ven
2008-09-23  2:58 ` [PATCH 2/2] corruption check: run the corruption checks from a work queue Arjan van de Ven
2008-09-23  6:03   ` Jeremy Fitzhardinge [this message]
2008-09-23  8:36 ` [PATCH 1/2] corruption check: move the corruption checks into their own file Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-09-21  3:35 [PATCH] x86: use round_jiffies() for the corruption check timer Arjan van de Ven
2008-09-22 21:04 ` [PATCH 1/2] corruption check: move the corruption checks into their own file Arjan van de Ven
2008-09-22 21:05   ` [PATCH 2/2] corruption check: run the corruption checks from a work queue Arjan van de Ven
2008-09-22 23:24     ` Arjan van de Ven
2008-09-22 23:28       ` Randy.Dunlap
2008-09-22 23:39         ` Arjan van de Ven
2008-09-23 11:33           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D886BB.80804@goop.org \
    --to=jeremy@goop.org \
    --cc=arjan@infradead.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.