From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, aliguori@codemonkey.ws
Subject: Re: [PATCH] Don't destroy vcpu in case vcpu_setup fails
Date: Tue, 23 Sep 2008 12:21:51 +0300 [thread overview]
Message-ID: <48D8B52F.9020505@redhat.com> (raw)
In-Reply-To: <1221704219-21523-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> One of vcpu_setup responsibilities is to do mmu initialization.
> However, in case we fail in kvm_arch_vcpu_reset, before we get the
> chance to init mmu. OTOH, vcpu_destroy will attempt to destroy mmu,
> triggering a bug. Keeping track of whether or not mmu is initialized
> would unnecessarily complicate things. Rather, we just make return,
> making sure any needed uninitialization is done before we return, in
> case we fail.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-09-23 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 2:16 [PATCH] Don't destroy vcpu in case vcpu_setup fails Glauber Costa
2008-09-23 9:21 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D8B52F.9020505@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@codemonkey.ws \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.