From: Avi Kivity <avi@redhat.com>
To: ncmike@ncultra.org
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] [KVM-userspace] remove compatibility code related to CONFIG_DMAR
Date: Tue, 23 Sep 2008 12:25:28 +0300 [thread overview]
Message-ID: <48D8B608.4020707@redhat.com> (raw)
In-Reply-To: <20080917164457.GB2774@silverwood.ncultra.org>
Mike Day wrote:
> Compatibility code for intel_iommu no longer needed when
> dependency on CONFIG_DMAR removed from kvm kernel build.
>
> Signed-off-by: Mike D. Day <ncmike@ncultra.org>
> ---
> external-module-compat.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/kernel/external-module-compat.c b/kernel/external-module-compat.c
> index 4b9a9f2..71429c7 100644
> --- a/kernel/external-module-compat.c
> +++ b/kernel/external-module-compat.c
> @@ -265,14 +265,3 @@ struct pci_dev *pci_get_bus_and_slot(unsigned int bus, unsigned int devfn)
> }
>
> #endif
> -
> -#include <linux/intel-iommu.h>
> -
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28)
> -
> -int intel_iommu_found()
> -{
> - return 0;
> -}
> -
> -#endif
>
>
Older kernels won't have intel_iommu_found() even with your other patch,
so this code is still needed.
We can't compile the external module on a 2.6.27 tree that has the iommu
patched in; we can probably make this work by renaming
intel_iommu_found() to kvm_intel_iommu_found() in hack-module.awk.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-09-23 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 16:44 [PATCH] [KVM-userspace] remove compatibility code related to CONFIG_DMAR Mike Day
2008-09-18 14:07 ` [PATCH] [KVM-userspace] remove compatibility code related toCONFIG_DMAR Han, Weidong
2008-09-18 14:44 ` Mike Day
2008-09-19 1:34 ` Han, Weidong
2008-09-23 9:25 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D8B608.4020707@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=ncmike@ncultra.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.