From: "Chris Friesen" <cfriesen@nortel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched: trivial fix for incorrect comments
Date: Tue, 23 Sep 2008 10:08:04 -0600 [thread overview]
Message-ID: <48D91464.9010501@nortel.com> (raw)
In-Reply-To: <20080922110049.GA5987@elte.hu>
Ingo Molnar wrote:
> * Chris Friesen <cfriesen@nortel.com> wrote:
>
>> From: Chris Friesen <cfriesen@nortel.com>
>>
>> A couple of the comments for the conditional definitions in sched.c are
>> incorrect. Here's a trivial patch fixing them up.
>
> looks good to me, but the patch is whitespace corrupted. Please see
> Documentation/email-clients.txt about how to send plain-text patches.
>
> Ingo
>
Actually, I thought I was following the procedures in there. It turns out
that older Thunderbird requires an external editor, disabling
format=flowed, and a line wrap of 0. The email clients doc makes it sound
like if you use an external editor you don't need the other parts. With
current Thunderbird the external editor is still not sufficient by itself,
but isn't required if the other two items are configured properly.
Here's another try.
---
From: Chris Friesen <cfriesen@nortel.com>
Subject: [PATCH] sched: trivial fix for incorrect comments
A couple of the comments for the conditional definitions in sched.c are
incorrect. Here's a trivial patch fixing them up.
Signed-off-by: Chris Friesen <cfriesen@nortel.com>
Approval token "Nortel-02-July-2008-01"
---
kernel/sched.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index cc1f81b..8ddca50 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -298,9 +298,9 @@ static DEFINE_PER_CPU(struct cfs_rq, init_cfs_rq) ____cacheline_aligned_in_smp;
static DEFINE_PER_CPU(struct sched_rt_entity, init_sched_rt_entity);
static DEFINE_PER_CPU(struct rt_rq, init_rt_rq) ____cacheline_aligned_in_smp;
#endif /* CONFIG_RT_GROUP_SCHED */
-#else /* !CONFIG_FAIR_GROUP_SCHED */
+#else /* !CONFIG_USER_SCHED */
#define root_task_group init_task_group
-#endif /* CONFIG_FAIR_GROUP_SCHED */
+#endif /* CONFIG_USER_SCHED */
/* task_group_lock serializes add/remove of task groups and also changes to
* a task group's cpu shares.
next prev parent reply other threads:[~2008-09-23 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 15:49 [patch] sched: trivial fix for incorrect comments Chris Friesen
2008-09-22 11:00 ` Ingo Molnar
2008-09-23 16:08 ` Chris Friesen [this message]
2008-09-27 18:10 ` Ingo Molnar
2008-09-27 18:19 ` Peter Zijlstra
2008-09-27 18:22 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D91464.9010501@nortel.com \
--to=cfriesen@nortel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.