From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] VT-d: remove useless header inclusion
Date: Wed, 24 Sep 2008 12:13:48 +0300
Message-ID: <48DA04CC.7020207@redhat.com>
References: <0122C7C995D32147B66BF4F440D3016301C49DDF@pdsmsx415.ccr.corp.intel.com> <48DA0078.10908@redhat.com> <0122C7C995D32147B66BF4F440D3016301C4A0B2@pdsmsx415.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Kay, Allen M" <allen.m.kay@intel.com>,
	"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Amit Shah <amit.shah@redhat.com>,
	"Yang, Sheng" <sheng.yang@intel.com>
To: "Han, Weidong" <weidong.han@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:51777 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751592AbYIXJOs (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Sep 2008 05:14:48 -0400
In-Reply-To: <0122C7C995D32147B66BF4F440D3016301C4A0B2@pdsmsx415.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Han, Weidong wrote:
> Avi Kivity wrote:
>   
>> Han, Weidong wrote:
>>     
>>> Currently "#include <linux/intel-iommu.h>" is not needed in
>>> virt/kvm/kvm_main.c. What's more, this inclusion may result in
>>> compilation error in other architecture.
>>>
>>>
>>>       
>> Applied, but please also fix intel-iommu.h to compile on all archs.
>>     
>
> Avi,
>
> Current intel-iommu.h should be compiled on all archs. On linux-next,
> they moved __iommu_clflush_cache() definition to intel-iomm.h, which
> results in it cannot pass compilation on some archs, such as IA64.
>   

Well, it still wants fixing, even if it is in linux-next only.

-- 
error compiling committee.c: too many arguments to function