All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: linux-kernel@vger.kernel.org, lists@ku-gbr.de, bhalevy.lists@gmail.com
Subject: Re: SATA Cold Boot problems on >2.6.25 with NV
Date: Wed, 24 Sep 2008 18:36:44 +0900	[thread overview]
Message-ID: <48DA0A2C.8010008@kernel.org> (raw)
In-Reply-To: <20080924084846.GA2094@anita>

[-- Attachment #1: Type: text/plain, Size: 122 bytes --]

Please apply the attached patch and post the resulting log.  Please
don't forget to turn on KALLSYMS.

Thanks.

-- 
tejun

[-- Attachment #2: sata_nv-eh-debug.patch --]
[-- Type: text/x-patch, Size: 1120 bytes --]

---
 drivers/ata/libata-eh.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Index: tree0/drivers/ata/libata-eh.c
===================================================================
--- tree0.orig/drivers/ata/libata-eh.c
+++ tree0/drivers/ata/libata-eh.c
@@ -671,6 +671,9 @@ static void ata_eh_set_pending(struct at
 
 	ap->pflags |= ATA_PFLAG_EH_PENDING;
 
+	ata_port_printk(ap, KERN_INFO, "XXX EH_SET_PENDING\n");
+	dump_stack();
+
 	if (!fastdrain)
 		return;
 
@@ -1077,6 +1080,11 @@ void ata_eh_about_to_do(struct ata_link
 	struct ata_eh_context *ehc = &link->eh_context;
 	unsigned long flags;
 
+	if (link)
+		ata_link_printk(link, KERN_INFO, "XXX about_to_do %x\n", action);
+	else if (dev)
+		ata_dev_printk(dev, KERN_INFO, "XXX about_to_do %x\n", action);
+
 	spin_lock_irqsave(ap->lock, flags);
 
 	ata_eh_clear_action(link, dev, ehi, action);
@@ -1890,8 +1898,8 @@ static void ata_eh_link_report(struct at
 		nr_failed++;
 	}
 
-	if (!nr_failed && !ehc->i.err_mask)
-		return;
+	//if (!nr_failed && !ehc->i.err_mask)
+	//	return;
 
 	frozen = "";
 	if (ap->pflags & ATA_PFLAG_FROZEN)

  reply	other threads:[~2008-09-24  9:38 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.CVrJhjm3R8sjl5Z+EEIzYm7QtW0@ifi.uio.no>
2008-08-29 14:44 ` SATA Cold Boot problems on >2.6.25 with NV Robert Hancock
2008-08-29 14:52   ` Tejun Heo
2008-08-29 21:21     ` Konstantin Kletschke
2008-08-30  9:14       ` Tejun Heo
2008-08-30 20:51         ` Konstantin Kletschke
2008-09-01 11:18           ` Tejun Heo
2008-09-01 17:46             ` Konstantin Kletschke
2008-09-02  4:35               ` Tejun Heo
2008-09-02  5:43                 ` Konstantin Kletschke
2008-09-02  5:45                   ` Tejun Heo
2008-09-02  6:36                     ` Konstantin Kletschke
2008-09-23  7:36         ` Benny Halevy
2008-09-24  8:48           ` Konstantin Kletschke
2008-09-24  9:36             ` Tejun Heo [this message]
2008-09-24 10:59               ` Konstantin Kletschke
2008-09-25  8:18                 ` Konstantin Kletschke
2008-09-27 21:22                   ` Tejun Heo
2008-09-30  8:12                     ` Konstantin Kletschke
2008-09-30 14:09                       ` Tejun Heo
2008-09-30 15:16                         ` Konstantin Kletschke
2008-09-30 16:47                           ` Tejun Heo
2008-10-01  7:38                             ` Konstantin Kletschke
2008-10-01  7:53                               ` Tejun Heo
2008-10-01 19:30                                 ` Konstantin Kletschke
2008-10-05 10:02               ` Benny Halevy
2008-10-05 10:18                 ` Tejun Heo
2008-10-05 10:34                   ` Benny Halevy
2008-10-05 10:42                     ` Tejun Heo
2008-10-05 11:18                       ` Benny Halevy
2008-10-06 21:19                       ` Konstantin Kletschke
2008-10-06 21:23                         ` Konstantin Kletschke
2008-10-07  1:02                           ` Tejun Heo
2008-10-07  6:04                             ` Konstantin Kletschke
2008-10-07  8:10                               ` Benny Halevy
2008-10-08  8:08                                 ` Konstantin Kletschke
2008-10-13  8:36                                   ` Tejun Heo
2008-10-13  8:38                                     ` Tejun Heo
2008-10-13 14:29                                       ` Konstantin Kletschke
2008-10-15  6:15                                         ` Tejun Heo
2008-10-17  8:08                                           ` Konstantin Kletschke
2008-10-21  6:08                                             ` Tejun Heo
2008-10-27  9:22                                           ` Konstantin Kletschke
2008-11-03  3:04                                             ` Tejun Heo
2008-11-03  8:32                                               ` Konstantin Kletschke
2008-12-14  0:49                                                 ` Erich Mounce
2008-12-14  3:51                                                   ` Tejun Heo
2008-10-13 14:25                                     ` Konstantin Kletschke
2008-09-25  8:15             ` Konstantin Kletschke
2008-08-29  7:47 Konstantin Kletschke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DA0A2C.8010008@kernel.org \
    --to=tj@kernel.org \
    --cc=bhalevy.lists@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@ku-gbr.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.