Re: [PATCH] remove kvm_init_ap from qemu code.

[Avi Kivity <avi@redhat.com>]

Glauber Costa wrote:
> Call it as a special case for cpu 0 creation. This removes
> a piece of kvm code from raw qemu.
>  
> +void kvm_init_new_ap(int cpu, CPUState *env)
> +{
> +    if (!cpu)
> +        kvm_init_ap();
> +
> +    pthread_create(&vcpu_info[cpu].thread, NULL, ap_main_loop, env);
> +
> +    while (vcpu_info[cpu].created == 0)
> +	qemu_cond_wait(&qemu_vcpu_cond);
> +}
> +
>   

kvm_init_ap() is machine-level initialization.  It's hacky to call it 
from cpu-level initialization.

Do we have a machine-level initialization hook?


[btw, !x makes sense when x is a boolean, pointer, or count.  Then it 
means "there is no x" or "there are no xs".  But when x is an index, !x 
means "x equals 0", so you may as well write that.

and don't get me started on !strcmp()]

-- 
error compiling committee.c: too many arguments to function