From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Date: Wed, 24 Sep 2008 11:28:37 +0000 Subject: [patch] do not allocate code_gen buffer on ia64 Message-Id: <48DA2465.1040709@sgi.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------040600060404000608060600" List-Id: To: kvm-ia64@vger.kernel.org This is a multi-part message in MIME format. --------------040600060404000608060600 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > Jes Sorensen wrote: >> Hi, >> >> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4 >> really gets out of hand when you boot say a 64GB guest. > > ia64 doesn't codegen; why not set it to zero? How about this one then? Jes --------------040600060404000608060600 Content-Type: text/plain; name="1200-ia64-code-gen-buffer.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="1200-ia64-code-gen-buffer.patch" Do not allocate a code_gen buffer on ia64 given it doesn't support code generation. Signed-off-by: Jes Sorensen --- qemu/exec.c | 4 ++++ 1 file changed, 4 insertions(+) Index: kvm-userspace.git/qemu/exec.c =================================================================== --- kvm-userspace.git.orig/qemu/exec.c +++ kvm-userspace.git/qemu/exec.c @@ -407,6 +407,10 @@ static void code_gen_alloc(unsigned long tb_size) { +#ifdef TARGET_IA64 + return; +#endif + #ifdef USE_STATIC_CODE_GEN_BUFFER code_gen_buffer = static_code_gen_buffer; code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE; --------------040600060404000608060600-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: [patch] do not allocate code_gen buffer on ia64 Date: Wed, 24 Sep 2008 13:28:37 +0200 Message-ID: <48DA2465.1040709@sgi.com> References: <48DA061A.20705@sgi.com> <48DA1D49.80108@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040600060404000608060600" Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: Avi Kivity Return-path: Received: from relay1.sgi.com ([192.48.171.29]:33667 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751452AbYIXL2k (ORCPT ); Wed, 24 Sep 2008 07:28:40 -0400 In-Reply-To: <48DA1D49.80108@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------040600060404000608060600 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > Jes Sorensen wrote: >> Hi, >> >> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4 >> really gets out of hand when you boot say a 64GB guest. > > ia64 doesn't codegen; why not set it to zero? How about this one then? Jes --------------040600060404000608060600 Content-Type: text/plain; name="1200-ia64-code-gen-buffer.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="1200-ia64-code-gen-buffer.patch" Do not allocate a code_gen buffer on ia64 given it doesn't support code generation. Signed-off-by: Jes Sorensen --- qemu/exec.c | 4 ++++ 1 file changed, 4 insertions(+) Index: kvm-userspace.git/qemu/exec.c =================================================================== --- kvm-userspace.git.orig/qemu/exec.c +++ kvm-userspace.git/qemu/exec.c @@ -407,6 +407,10 @@ static void code_gen_alloc(unsigned long tb_size) { +#ifdef TARGET_IA64 + return; +#endif + #ifdef USE_STATIC_CODE_GEN_BUFFER code_gen_buffer = static_code_gen_buffer; code_gen_buffer_size = DEFAULT_CODE_GEN_BUFFER_SIZE; --------------040600060404000608060600--