From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: RE: MSI causing softpanics in guest
Date: Wed, 24 Sep 2008 11:59:43 +0100
Message-ID: <48DA39BF.76E4.0078.0@novell.com>
References: <F6473715D25C9E46A5515027E5482F100887BDB0F9@pdsmsx502.ccr.corp.intel.com>
	<C4FF9708.1D821%keir.fraser@eu.citrix.com>
	<F6473715D25C9E46A5515027E5482F100887BDB2C6@pdsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <F6473715D25C9E46A5515027E5482F100887BDB2C6@pdsmsx502.ccr.corp.intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Haitao Shan <haitao.shan@intel.com>
Cc: Anish Bhatt <anish@cc.gatech.edu>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Keir Fraser <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

>--- a/drivers/pci/msi-xen.c	Mon Sep 22 16:08:10 2008 +0100
>+++ b/drivers/pci/msi-xen.c	Wed Sep 24 01:45:16 2008 +0800
>@@ -158,7 +158,11 @@ static int msi_unmap_pirq(struct pci_dev
> 	int rc;
>=20
> 	unmap.domid =3D msi_get_dev_owner(dev);
>-	unmap.pirq =3D evtchn_get_xen_pirq(pirq);
>+	/* See comments in msi_map_pirq_to_vector, input parameter pirq
>+	 * mean irq number only if the device belongs to dom0 itself.
>+	 */
>+	if (unmap.domid =3D=3D DOMID_SELF)
>+		unmap.pirq =3D evtchn_get_xen_pirq(pirq);

This seems to leave unmap.pirq uninitialized in the !DOMID_SELF case.

Otherwise, seems a reasonable alternative to doing it in pcifront/pciback.

Jan