From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Ryan Harper <ryanh@us.ibm.com>,
kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] Implement an fd pool to get real AIO with posix-aio
Date: Wed, 24 Sep 2008 09:17:07 -0500 [thread overview]
Message-ID: <48DA4BE3.30403@us.ibm.com> (raw)
In-Reply-To: <48DA021F.2050504@redhat.com>
Avi Kivity wrote:
> Anthony Liguori wrote:
>
> dup()ing the fd on each request is unnecessary work; would be better
> to cache the duped fd.
Yeah, I was concerned about this too. Ryan reran the fio benchmark and
the submission latency and completion latency were identical to the
linux-aio patches. That suggests that the overhead of dup() is lost in
the noise.
Since this is simpler and keeps the number of open file descriptors as
low as possible, I was happy about that.
Regards,
Anthony Liguori
> Of course, if this is just a stepping stone, it doesn't matter very much.
>
prev parent reply other threads:[~2008-09-24 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 20:34 [PATCH] Implement an fd pool to get real AIO with posix-aio Anthony Liguori
2008-09-24 9:02 ` Avi Kivity
2008-09-24 14:17 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DA4BE3.30403@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.