From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Date: Wed, 24 Sep 2008 15:33:34 +0000 Subject: Re: [patch] do not allocate code_gen buffer on ia64 Message-Id: <48DA5DCE.4020707@codemonkey.ws> List-Id: References: <48DA2465.1040709@sgi.com> In-Reply-To: <48DA2465.1040709@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Avi Kivity wrote: > Jes Sorensen wrote: >> Avi Kivity wrote: >>> Jes Sorensen wrote: >>>> Hi, >>>> >>>> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4 >>>> really gets out of hand when you boot say a 64GB guest. >>> >>> ia64 doesn't codegen; why not set it to zero? >> >> How about this one then? >> > > Applied, thanks. Note qemu uses 4 spaces for intedenation. Talk to > your editor. It would seem better to replace #ifdef TARGET_IA64 with if (kvm_enabled()). If QEMU ever got proper ia64 target support, that's going to be an ugly bug to find. Regards, Anthony Liguori From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [patch] do not allocate code_gen buffer on ia64 Date: Wed, 24 Sep 2008 10:33:34 -0500 Message-ID: <48DA5DCE.4020707@codemonkey.ws> References: <48DA061A.20705@sgi.com> <48DA1D49.80108@redhat.com> <48DA2465.1040709@sgi.com> <48DA2705.8040602@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jes Sorensen , kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: Avi Kivity Return-path: Received: from yw-out-2324.google.com ([74.125.46.30]:37820 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbYIXPef (ORCPT ); Wed, 24 Sep 2008 11:34:35 -0400 Received: by yw-out-2324.google.com with SMTP id 9so412455ywe.1 for ; Wed, 24 Sep 2008 08:34:33 -0700 (PDT) In-Reply-To: <48DA2705.8040602@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Jes Sorensen wrote: >> Avi Kivity wrote: >>> Jes Sorensen wrote: >>>> Hi, >>>> >>>> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4 >>>> really gets out of hand when you boot say a 64GB guest. >>> >>> ia64 doesn't codegen; why not set it to zero? >> >> How about this one then? >> > > Applied, thanks. Note qemu uses 4 spaces for intedenation. Talk to > your editor. It would seem better to replace #ifdef TARGET_IA64 with if (kvm_enabled()). If QEMU ever got proper ia64 target support, that's going to be an ugly bug to find. Regards, Anthony Liguori