From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754425AbYIYCPA (ORCPT ); Wed, 24 Sep 2008 22:15:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752499AbYIYCOq (ORCPT ); Wed, 24 Sep 2008 22:14:46 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:56506 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbYIYCOp (ORCPT ); Wed, 24 Sep 2008 22:14:45 -0400 Message-ID: <48DAF40D.3040005@garzik.org> Date: Wed, 24 Sep 2008 22:14:37 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: "Brandeburg, Jesse" CC: Jeff Kirsher , mingo@elte.hu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, akpm@linux-foundation.org Subject: Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split References: <20080827081956.11114.152.stgit@jtkirshe-mobile.jf.intel.com> <48BE982C.20705@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brandeburg, Jesse wrote: > On Wed, 3 Sep 2008, Jeff Garzik wrote: >>> From: Jesse Brandeburg >>> >>> Since the e1000/e1000e split, no hardware supported by e1000 >>> supports packet split, just remove the Kconfig option and associated >>> code from arch/* and the driver. >>> >>> Signed-off-by: Jesse Brandeburg >>> Signed-off-by: Jeff Kirsher >>> --- >>> >>> arch/arm/configs/iop13xx_defconfig | 1 >>> arch/arm/configs/iop32x_defconfig | 1 >> ACK, except for the defconfig changes. arch maintainers usually prefer to do >> that themselves. >> >> We'd be continually patch defconfig files, if we did so every time it was >> likely one would be updated by a Kconfig patch. > > Here is an updated patch without the defconfig changes > > == cut here == > > e1000: remove Kconfig option for packet split and e1000 related code > > From: Jesse Brandeburg > > Since the e1000/e1000e split, no hardware supported by e1000 > supports packet split, just remove the Kconfig option and associated > code from the driver. > > reposted without the defconfig changes, should apply to net-next > > Signed-off-by: Jesse Brandeburg > --- > drivers/net/Kconfig | 9 - > drivers/net/e1000/e1000.h | 17 -- > drivers/net/e1000/e1000_main.c | 416 +--------------------------------------- > 3 files changed, 9 insertions(+), 433 deletions(-) applied