All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, Pekka Paalanen <pq@iki.fi>
Subject: [Patch -tip 3/3] Tracing/ftrace: Don't consume entries unhandled by mmiotrace
Date: Thu, 25 Sep 2008 13:28:56 +0100	[thread overview]
Message-ID: <48DB8408.7080408@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

When mmiotrace can't handle an entry output, it returns 1.
It should return 0 to relay on other output functions.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---

[-- Attachment #2: 3.diff --]
[-- Type: text/plain, Size: 433 bytes --]

diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
index a108c32..6fe1315 100644
--- a/kernel/trace/trace_mmiotrace.c
+++ b/kernel/trace/trace_mmiotrace.c
@@ -277,7 +277,8 @@ static int mmio_print_line(struct trace_iterator *iter)
 	case TRACE_PRINT:
 		return mmio_print_mark(iter);
 	default:
-		return 1; /* ignore unknown entries */
+		return 0; /* ignore unknown entries whithout consuming */
 	}
 }
 

             reply	other threads:[~2008-09-25 11:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 12:28 Frédéric Weisbecker [this message]
2008-09-25 12:56 ` [Patch -tip 3/3] Tracing/ftrace: Don't consume entries unhandled by mmiotrace Ingo Molnar
2008-09-25 14:34 ` Pekka Paalanen
2008-09-25 14:44   ` Frédéric Weisbecker
2008-09-25 15:36     ` Pekka Paalanen
2008-09-25 16:13       ` Frédéric Weisbecker
2008-09-27 17:47         ` Ingo Molnar
2008-09-27 18:25           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DB8408.7080408@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pq@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.