From: Anthony Liguori <anthony@codemonkey.ws>
To: Juergen Lock <nox@jelal.kn-bremen.de>,
qemu-devel@nongnu.org, freebsd-emulation@freebsd.org
Subject: Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c
Date: Thu, 25 Sep 2008 15:39:58 -0500 [thread overview]
Message-ID: <48DBF71E.1000405@codemonkey.ws> (raw)
In-Reply-To: <20080925201703.GA12142@saturn.kn-bremen.de>
Juergen Lock wrote:
> I forgot to note that this also needed the following patch:
>
Why? This #ifdef is working around a very specific bug.
Regards,
Anthony Liguori
> Index: qemu/block-raw-posix.c
> @@ -545,7 +545,8 @@
>
> qemu_aio_set_fd_handler(s->fd, posix_aio_read, NULL, posix_aio_flush, s);
>
> -#if defined(__linux__) && defined(__GLIBC_PREREQ) && !__GLIBC_PREREQ(2, 4)
> +#if defined(__linux__) && defined(__GLIBC_PREREQ)
> +#if !__GLIBC_PREREQ(2, 4)
> {
> /* XXX: aio thread exit seems to hang on RedHat 9 and this init
> seems to fix the problem. */
> @@ -557,6 +558,7 @@
> aio_init(&ai);
> }
> #endif
> +#endif
> posix_aio_state = s;
>
> return 0;
>
> Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
>
>
>
next prev parent reply other threads:[~2008-09-25 20:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 20:40 [Qemu-devel] qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates Juergen Lock
2008-09-22 15:30 ` Anthony Liguori
2008-09-24 21:52 ` Juergen Lock
2008-09-23 13:39 ` [Qemu-devel] " Matt
2008-09-24 22:10 ` [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313) Juergen Lock
2008-09-25 2:54 ` Matt
2008-09-26 15:04 ` Anthony Liguori
2008-09-26 15:52 ` Carlos A. M. dos Santos
2008-09-26 22:04 ` Juergen Lock
2008-09-27 15:33 ` Anthony Liguori
2008-09-27 22:52 ` Juergen Lock
2008-09-30 14:51 ` Anthony Liguori
2008-09-30 22:17 ` Juergen Lock
2008-09-27 20:47 ` [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331) Juergen Lock
2008-09-28 4:04 ` Carlos A. M. dos Santos
2008-09-30 22:33 ` Juergen Lock
2008-10-11 21:41 ` [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5457) Juergen Lock
2008-10-18 20:46 ` [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5499) Juergen Lock
2008-09-30 14:52 ` [Qemu-devel] Re: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5331) Anthony Liguori
2008-09-30 22:35 ` Juergen Lock
2008-09-25 20:17 ` [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c (was: qemu svn r5281 on FreeBSD - slow usb, vmwarevga, screen updates... (now updated to r5313)) Juergen Lock
2008-09-25 20:39 ` Anthony Liguori [this message]
2008-09-26 21:29 ` [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c Juergen Lock
2008-09-27 15:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DBF71E.1000405@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=freebsd-emulation@freebsd.org \
--cc=nox@jelal.kn-bremen.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.