All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave <kilroyd@googlemail.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wireless: consolidate on a single escape_essid implementation
Date: Fri, 26 Sep 2008 00:03:30 +0100	[thread overview]
Message-ID: <48DC18C2.1020705@gmail.com> (raw)
In-Reply-To: <20080924232453.GG9187@tesla>

Luis R. Rodriguez wrote:
> Which reminds me, net/ieee80211/ should be ipw'ized now that the
> old softmac drivers are gone.
> 
> mcgrof@tesla ~/wireless-testing/drivers/net/wireless (git::v2.6.27-rc6)$ grep -nHr "#include <net/ieee80211.h>" *
> orinoco.c:88:#include <net/ieee80211.h>
> 
> Whatever these suckers are using can probably be slapped in there as
> well. But yea -- we just need to get it done huh.

Almost all of what orinoco uses can now be sourced from <linux/ieee80211.h> instead. However there are the following constants:

Missing:
MAX_WPA_IE_LEN (64)
WEP_KEYS (4)

Possible alternative, but change in value:
IEEE80211_FRAME_LEN (2334) != IEEE80211_MAX_FRAME_LEN (2352)

Obviously these can be defined locally if we're not sure if they should be global, or where they belong.



Regards,

Dave.

  parent reply	other threads:[~2008-09-25 23:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24 22:15 [PATCH] wireless: consolidate on a single escape_essid implementation John W. Linville
2008-09-24 23:24 ` Luis R. Rodriguez
2008-09-24 23:32   ` John W. Linville
2008-09-25  0:21     ` Luis R. Rodriguez
2008-09-25  0:39       ` John W. Linville
2008-09-25  1:52         ` Luis R. Rodriguez
2008-09-25  6:34     ` Holger Schurig
2008-09-25  8:43       ` Johannes Berg
2008-09-25 16:57         ` Dan Williams
2008-09-26 11:08           ` Johannes Berg
2008-09-26 14:51             ` Johannes Berg
2008-09-26 14:57           ` Johannes Berg
2008-09-25 23:03   ` Dave [this message]
2008-09-25  4:46 ` Johannes Berg
2008-09-25  4:49   ` Johannes Berg
2008-09-25 16:47     ` Dan Williams
2008-09-25 16:48   ` Dan Williams
2008-09-25 21:00 ` Dave
2008-10-01  2:15 ` [PATCH 0/5] wireless: single escape_essid implementation and related cleanups John W. Linville
2008-10-01  2:15   ` [PATCH 1/5] wireless: consolidate on a single escape_essid implementation John W. Linville
2008-10-01  2:15     ` [PATCH 2/5] wireless: remove NETWORK_EMPTY_ESSID flag John W. Linville
2008-10-01  2:15       ` [PATCH 3/5] wireless: escape_ssid should handle non-printables John W. Linville
2008-10-01  2:15         ` [PATCH 4/5] wireless: use individual buffers for printing ssid values John W. Linville
2008-10-01  2:15           ` [PATCH 5/5] wireless: avoid some net/ieee80211.h vs. linux/ieee80211.h conflicts John W. Linville
2008-10-01  9:25   ` [PATCH 0/5] wireless: single escape_essid implementation and related cleanups Johannes Berg
2008-10-02 19:10   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DC18C2.1020705@gmail.com \
    --to=kilroyd@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.