From: Johannes Sixt <j.sixt@viscovery.net>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] git-gui: Help identify aspell version on Windows too
Date: Fri, 26 Sep 2008 11:31:52 +0200 [thread overview]
Message-ID: <48DCAC08.9060004@viscovery.net> (raw)
In-Reply-To: <48DCA5F3.4090009@isy.liu.se>
Gustaf Hendeby schrieb:
> On 09/26/2008 08:29 AM, Johannes Sixt wrote:
>> Gustaf Hendeby schrieb:
>>> On windows, git gui fails to correctly extract the aspell version
>>> (experienced with aspell version 0.50.3) due to scilent white space at
>>> the end of the version string. Trim the obtained version string to
>>> work around this.
>> With this I've partial success here: Aspell 0.50.3 alpha (downloaded from
>> http://aspell.net/win32/) is recognized, but
>>
>> - it only ever checks the first line of the commit message;
>
> Hmm, strange, I just had it mark my whole first like red, I think it
> took an enter at the end of the line to get everything started though.
> Does it check the rest of the lines for you? I know spell checking is
> disabled for too early versions of Aspell, due to some change in the
> interface I think.
My situation is this: I fire up git-gui, and because I have some stale
.git/GITGUI_MSG file, the commit message box is not empty. Aspell begins
its work, and git-gui correctly marks spelling mistakes in the first line.
Even if I type new text, delete old text, or change the whole text by
clicking "Amend", no new spelling mistakes are marked for the whole session.
-- Hannes
next prev parent reply other threads:[~2008-09-26 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 21:31 [PATCH] git-gui: Help identify aspell version on Windows too Gustaf Hendeby
2008-09-26 6:29 ` Johannes Sixt
2008-09-26 9:05 ` Gustaf Hendeby
2008-09-26 9:31 ` Johannes Sixt [this message]
2008-09-26 14:31 ` Shawn O. Pearce
2008-09-26 15:06 ` Johannes Sixt
2008-09-26 14:28 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DCAC08.9060004@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=hendeby@isy.liu.se \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.