From: Jes Sorensen <jes@sgi.com>
To: Glauber Costa <glommer@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: change in 'smp_cpus' at runtime vs vcpu_info?
Date: Fri, 26 Sep 2008 16:46:25 +0200 [thread overview]
Message-ID: <48DCF5C1.3000205@sgi.com> (raw)
In-Reply-To: <5d6222a80809260739i4eb39d6fn6a26027c9646383a@mail.gmail.com>
Glauber Costa wrote:
> On Fri, Sep 26, 2008 at 11:31 AM, Jes Sorensen <jes@sgi.com> wrote:
>> Hmmm. I don't see any reference to MAX_CPUS in hw/apic.c, any chance you
>> can give me a pointer?
>
> sorry. That's not apic (damn acronyms), It's acpi.
> But the reference to MAX_CPUS is at bios/rombios32.c when building the tables.
> the acpi code just fire them out.
Oh, that seems to be x86 gibberish though :-)
Well the point is that qemu-kvm.c seems to loop over the vcpu_info array
based on smp_cpus, so if we hotplug a CPU and smp_cpus isn't updated,
which I cannot find any place that does, then we'll end up looping over
only a subset of cpus?
or am I missing something here?
Cheers,
Jes
prev parent reply other threads:[~2008-09-26 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 14:17 change in 'smp_cpus' at runtime vs vcpu_info? Jes Sorensen
2008-09-26 14:28 ` Glauber Costa
2008-09-26 14:31 ` Jes Sorensen
2008-09-26 14:39 ` Glauber Costa
2008-09-26 14:46 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DCF5C1.3000205@sgi.com \
--to=jes@sgi.com \
--cc=glommer@gmail.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.