Anthony Liguori wrote:
> Jason Wessel wrote:
>> Anthony if that is all that you consider to be blocking a commit,
>> attached is a fixed version with white space and comments fixups.
>>  
>
> Hi Jason,
>
> Thanks for trying to help, but it's *still* whitespace damaged.  This
> may seem like a minor nit but not taking the time to try and make code
> match up with the rest of the source tree doesn't suggest that much time
> has been taking to make the code fit in architecturally or to think
> about any sort of wider interactions.  I also like to give an author the
> chance to fix something because it helps encourage people to do the
> right thing the first time around.
>

While I agree in part, it is also frustrating when you want to put
changes on top someone else's work that is changing.  It is in the
spirit of trying to stabilize this patch that I offered a bit of
assistance.

The rest of your concerns to the white space fixes are addressed in
the next version here.

I also fixed the instances of:
    if (f) ...
to be:
    if (f)
        ...

As well a closing else {} problem:
    if () {
        ...
    } else
        ...
to be:
    if () {
        ...
    } else {
        ...
    }

Perhaps further technical review can occur with no more white space issues?

My comment on technical content would be that the several places that
atoi() and strtoul() the values are not checked for any kind of
correctness and subsequently pass on.  Perhaps no validity check is
needed because it is dealt with in the later call to the passed in
function...  It just was not immediately obvious.

Jason.