All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhai, Edwin" <edwin.zhai@intel.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: super page with live migration
Date: Sat, 27 Sep 2008 17:19:15 +0800	[thread overview]
Message-ID: <48DDFA93.7070607@intel.com> (raw)
In-Reply-To: <C5026407.277BC%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> On 26/9/08 08:45, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:
>
>   
>> As you know, we try to allocate super pages in xc_hvm_build for better
>> performance in EPT case. But the same logic is missing in xc_domain_restore.
>>
>> When try to add the logic, I found it is blocked by the lazy populate
>> algorithm 
>> in restore -- only populating the pages received from source side rather than
>> doing it at one time.
>>
>> So the result is the EPT guest has performance drop after live migration:(
>>
>> Do you have any plan to change the lazy populate algorithm? The purpose of it,
>> I 
>> believe, is to make restore process work without guest memory layout
>> knowledge.  
>>     
>
> Yes: If pseudo-phys page is not yet populated in target domain, AND it is
> first page of a 2MB extent, AND no other pages in that extent are yet
> populated, AND the next pages in the save-image stream populate that extent
> in order, THEN allocate a superpage. This is made trickier by the fact that
> the next 511 pages (to make the 2MB extent) might be split across a batch
> boundary. So we'll have to optimistically allocate a superpage in that case,
> and then shatter it if it turns out that the contiguous stream of
> pseudo-phys addresses is broken in the next batch.
>   

It's really tricky logic, and may make the migration process longer:(

Maybe the flag the start-of-a-superpage as Tim said can make it easier.



Thanks,


>  -- Keir
>
>
>   

      parent reply	other threads:[~2008-09-27  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26  7:45 super page with live migration Zhai, Edwin
2008-09-26  9:03 ` Keir Fraser
2008-09-26  9:08   ` Tim Deegan
2008-09-26  9:28     ` Keir Fraser
2008-09-26 10:18       ` Ian Pratt
2008-09-28  6:51         ` Tian, Kevin
2008-09-28 14:16           ` Ian Pratt
2008-10-06  0:45             ` Tian, Kevin
2008-09-27  9:19   ` Zhai, Edwin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DDFA93.7070607@intel.com \
    --to=edwin.zhai@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.