All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	kvm@vger.kernel.org, Amit Shah <amit.shah@redhat.com>,
	"Kay, Allen M" <allen.m.kay@Intel.Com>,
	Ben-Ami Yassour1 <BENAMI@il.ibm.com>
Subject: Re: [PATCH] VT-d: Fix iommu map page for mmio pages
Date: Sat, 27 Sep 2008 13:24:31 +0300	[thread overview]
Message-ID: <48DE09DF.2050400@redhat.com> (raw)
In-Reply-To: <20080926235730.GE9118@il.ibm.com>

Muli Ben-Yehuda wrote:

  

>> MMIO isn't just a register window.  It may be an on-device buffer.
>>     
>
> Unlikely, but ok.
>
>   

It's unlikely in the same ways graphics cards are unlikely :)

With a multi-card setup, perhaps it is even reasonable for one card to 
dma to another.

> I strongly disagree. You are advocating something that is potentially
> unsafe---for the sake of code simplicity?! I am advocating caution in
> what we let an *untrusted* guest do.
>   

Why would it be unsafe?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2008-09-27 10:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19  7:15 [PATCH] VT-d: Fix iommu map page for mmio pages Han, Weidong
2008-09-25 10:27 ` Avi Kivity
2008-09-25 13:44   ` Han, Weidong
2008-09-25 13:58     ` Avi Kivity
2008-09-25 14:07       ` Han, Weidong
2008-09-25 14:45         ` Avi Kivity
2008-09-25 15:04           ` Anthony Liguori
2008-09-25 15:19             ` Han, Weidong
2008-09-25 21:14           ` Muli Ben-Yehuda
2008-09-25 21:51             ` Anthony Liguori
2008-09-26 23:57               ` Muli Ben-Yehuda
2008-09-27 10:24                 ` Avi Kivity [this message]
2008-09-28  6:07                   ` Muli Ben-Yehuda
2008-09-28  8:45                     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DE09DF.2050400@redhat.com \
    --to=avi@redhat.com \
    --cc=BENAMI@il.ibm.com \
    --cc=allen.m.kay@Intel.Com \
    --cc=amit.shah@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=muli@il.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.