All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-ext4@vger.kernel.org, Alex Tomas <alex@clusterfs.com>,
	Mike Travis <travis@sgi.com>
Subject: Re: Unusual code in mballoc.c.
Date: Sat, 27 Sep 2008 23:01:11 -0500	[thread overview]
Message-ID: <48DF0187.5030005@redhat.com> (raw)
In-Reply-To: <200809281156.12688.rusty@rustcorp.com.au>

Rusty Russell wrote:
> Hi all,
> 
>    A grep lead me to fs/ext4/mballoc.c:
> 
> Line 2551:
> 	for (i = 0; i < nr_cpu_ids; i++) {
> 
> This is more normally "for_each_possible_cpu(i)".
> 
> Line 4097:
> 	ac->ac_lg = &sbi->s_locality_groups[get_cpu()];
> 	put_cpu();
> 
> This is presumably someone suppressing a warning.   It should be:
> 	ac->ac_lg = &sbi->s_locality_groups[raw_smp_processor_id()];
> 
> Thanks,
> Rusty.

Hi Rusty - I sent a patch for this a while back...

http://repo.or.cz/w/ext4-patch-queue.git?a=blob;f=ext4-use-percpu-data-for-lg_prealloc_list;h=8ddebb7f6054f70e34b142d7ae6f314d6629aac7;hb=HEAD

Thanks,
-Eric

      reply	other threads:[~2008-09-28  4:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-28  1:56 Unusual code in mballoc.c Rusty Russell
2008-09-28  4:01 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DF0187.5030005@redhat.com \
    --to=sandeen@redhat.com \
    --cc=alex@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.