All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tomlohave@gmail.com" <tomlohave@gmail.com>
To: hermann pitton <hermann-pitton@arcor.de>
Cc: dabby bentam <db260179@hotmail.com>,
	linux-dvb@linuxtv.org, video4linux-list@redhat.com,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [linux-dvb] [PATCH] saa7134: add support for Tv(working	config), radio and analog audio in on the Hauppauge HVR-1110
Date: Sun, 28 Sep 2008 19:35:14 +0200	[thread overview]
Message-ID: <48DFC052.60005@gmail.com> (raw)
In-Reply-To: <1222619391.3423.30.camel@pc10.localdom.local>

hermann pitton a écrit :
> Hi,
>
> Am Sonntag, den 28.09.2008, 01:43 -0300 schrieb Mauro Carvalho Chehab:
>   
>> On Sat, 27 Sep 2008 06:39:54 +0200
>> hermann pitton <hermann-pitton@arcor.de> wrote:
>>
>>     
>>> Mauro,
>>>
>>> wait a little.
>>>       
>> OK. Please forward it to me again, after everything being ok with the patch.
>>
>> Cheers,
>> Mauro
>>     
>
> Thomas mailed me that he has some trouble with his current setup and
> might not be able to test that soon too.
>
> The patch is already OK and tested by David.
>
> David,
> as told, we need also your email in signed-off-by.
> I take it from the card's entry. Please give your OK.
>
> Here is it again with some cleanup for spaces.
> Mauro, please take it from the attachment.
> Evolution inline converts tabs to spaces or I must force it into a mode
> it does not like.
>
> Cheers,
> Hermann
>
>
> saa7134: Hauppauge HVR-1110, support for radio and analog audio in
>
> From: David Bentham <db260179@hotmail.com>
>
> The audio switch is at 0x100 and radio on gpio 21.
>
> Priority: normal
>
> Signed-off-by: David Bentham <db260179@hotmail.com>
> Reviewed-by: Hermann Pitton <hermann-pitton@arcor.de>
>
> diff -r 8e6cda021e0e linux/drivers/media/video/saa7134/saa7134-cards.c
> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c	Fri Sep 26 11:29:03 2008 +0200
> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c	Sun Sep 28 17:21:45 2008 +0200
> @@ -3299,6 +3299,7 @@
>  	},
>  	[SAA7134_BOARD_HAUPPAUGE_HVR1110] = {
>  		/* Thomas Genty <tomlohave@gmail.com> */
> +		/* David Bentham <db260179@hotmail.com> */
>  		.name           = "Hauppauge WinTV-HVR1110 DVB-T/Hybrid",
>  		.audio_clock    = 0x00187de7,
>  		.tuner_type     = TUNER_PHILIPS_TDA8290,
> @@ -3307,23 +3308,26 @@
>  		.radio_addr     = ADDR_UNSET,
>  		.tuner_config   = 1,
>  		.mpeg           = SAA7134_MPEG_DVB,
> -		.inputs         = {{
> -			.name = name_tv,
> -			.vmux = 1,
> -			.amux = TV,
> -			.tv   = 1,
> -		},{
> -			.name   = name_comp1,
> -			.vmux   = 3,
> -			.amux   = LINE2, /* FIXME: audio doesn't work on svideo/composite */
> -		},{
> -			.name   = name_svideo,
> -			.vmux   = 8,
> -			.amux   = LINE2, /* FIXME: audio doesn't work on svideo/composite */
> -		}},
> -		.radio = {
> -			.name = name_radio,
> -			.amux   = TV,
> +		.gpiomask       = 0x0200100,
> +		.inputs         = {{
> +			.name = name_tv,
> +			.vmux = 1,
> +			.amux = TV,
> +			.tv   = 1,
> +			.gpio = 0x0000100,
> +		}, {
> +			.name = name_comp1,
> +			.vmux = 3,
> +			.amux = LINE1,
> +		}, {
> +			.name = name_svideo,
> +			.vmux = 8,
> +			.amux = LINE1,
> +		} },
> +		.radio = {
> +			.name = name_radio,
> +			.amux = TV,
> +			.gpio = 0x0200100,
>  		},
>  	},
>  	[SAA7134_BOARD_CINERGY_HT_PCMCIA] = {
>
>   
It's ok for me
Tested-by: Thomas Genty <tomlohave@gmail.com>

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

      reply	other threads:[~2008-09-28 17:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 22:13 [linux-dvb] [PATCH] saa7134: add support for Tv(working config), radio and analog audio in on the Hauppauge HVR-1110 dabby bentam
2008-09-27  4:39 ` hermann pitton
2008-09-28  4:43   ` Mauro Carvalho Chehab
2008-09-28 16:29     ` hermann pitton
2008-09-28 17:35       ` tomlohave [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DFC052.60005@gmail.com \
    --to=tomlohave@gmail.com \
    --cc=db260179@hotmail.com \
    --cc=hermann-pitton@arcor.de \
    --cc=linux-dvb@linuxtv.org \
    --cc=mchehab@infradead.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.