All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donald Douwsma <donaldd@sgi.com>
To: Peter Leckie <pleckie@sgi.com>
Cc: xfs@oss.sgi.com, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH] Clean up dquot pincount code
Date: Mon, 29 Sep 2008 12:11:29 +1000	[thread overview]
Message-ID: <48E03951.5010704@sgi.com> (raw)
In-Reply-To: <48E02E3D.3000104@sgi.com>

Peter Leckie wrote:
> This is a fix for patch " Clean up dquot pincount code"
> which introduced a build breakage due to a missing & in
> xfs_qm_dquot_logitem_pin.
> 
> 
> Signed-off-by: Peter Leckie <pleckie@sgi.com>
> 
> Index: 2.6.x-xfs/fs/xfs/quota/xfs_dquot_item.c
> ===================================================================
> --- 2.6.x-xfs.orig/fs/xfs/quota/xfs_dquot_item.c
> +++ 2.6.x-xfs/fs/xfs/quota/xfs_dquot_item.c
> @@ -96,7 +96,7 @@ xfs_qm_dquot_logitem_pin(
>        xfs_dquot_t *dqp = logitem->qli_dquot;
> 
>        ASSERT(XFS_DQ_IS_LOCKED(dqp));
> -       atomic_inc(dqp->q_pincount);
> +       atomic_inc(&dqp->q_pincount);
> }
> 
> /*

Looks good Peter,

seems we all missed this in review :(

Don

  reply	other threads:[~2008-09-29  2:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26  4:11 [PATCH] Clean up dquot pincount code Peter Leckie
2008-09-26  4:30 ` Donald Douwsma
2008-09-26  4:33 ` Dave Chinner
2008-09-26  6:31 ` Christoph Hellwig
2008-09-29  1:24 ` Peter Leckie
2008-09-29  2:11   ` Donald Douwsma [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-30  2:17 (no subject) Peter Leckie
2008-09-30  2:22 ` [PATCH] Clean up dquot pincount code Peter Leckie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E03951.5010704@sgi.com \
    --to=donaldd@sgi.com \
    --cc=pleckie@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.