Re: [PATCH 1/2 v3] Introduce ata_id_has_unload()

[Jeff Garzik <jeff@garzik.org>]

Elias Oltmanns wrote:
> Add a function to check an ATA device's id for head unload support as
> specified in ATA-7.
> 
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
> ---
> 
>  include/linux/ata.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index cea079c..c66a7d6 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -707,6 +707,15 @@ static inline int ata_id_has_dword_io(const u16 *id)
>  	return 0;
>  }
>  
> +static inline int ata_id_has_unload(const u16 *id)
> +{
> +	if (ata_id_major_version(id) >= 7 &&
> +	    (id[ATA_ID_CFSSE] & 0xC000) == 0x4000 &&
> +	    id[ATA_ID_CFSSE] & (1 << 13))
> +		return 1;
> +	return 0;
> +}
> +
>  static inline int ata_id_current_chs_valid(const u16 *id)
>  {
>  	/* For ATA-1 devices, if the INITIALIZE DEVICE PARAMETERS command

applied 1-2