From: Lachlan McIlroy <lachlan@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: compiler warning after applying btree patches
Date: Mon, 29 Sep 2008 18:41:30 +1000 [thread overview]
Message-ID: <48E094BA.8060009@sgi.com> (raw)
In-Reply-To: <20080929073033.GA30795@infradead.org>
Christoph Hellwig wrote:
> On Mon, Sep 29, 2008 at 05:33:41PM +1000, Lachlan McIlroy wrote:
>> Christoph,
>>
>> After applying the first round of btree patches we've now got this warning
>> when building a non-debug xfs module.
>>
>> CC fs/xfs/xfs_btree.o
>> fs/xfs/xfs_btree.c:191: warning: ?xfs_btree_check_ptr? defined but not used
>>
>> I took a quick look through your next round of btree patches but couldn't
>> see a fix for it. Did I miss something in the original patch set? Is it
>> fixed in a later patch? If not here's a fix:
>
> No, it's not used for now. For some reason I missed the warning.
>
> The patch looks good, can you also put it into xfs-cmds so the two
> copies stay in sync?
Okay. Thanks.
prev parent reply other threads:[~2008-09-29 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 7:33 compiler warning after applying btree patches Lachlan McIlroy
2008-09-29 7:30 ` Christoph Hellwig
2008-09-29 8:41 ` Lachlan McIlroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E094BA.8060009@sgi.com \
--to=lachlan@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.