All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chris Friesen" <cfriesen@nortel.com>
To: "Amit K. Arora" <aarora@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, vatsa@linux.vnet.ibm.com,
	a.p.zijlstra@chello.nl, mingo@elte.hu
Subject: Re: [PATCH] sched: minor optimizations in wake_affine and select_task_rq_fair
Date: Mon, 29 Sep 2008 10:09:41 -0600	[thread overview]
Message-ID: <48E0FDC5.1080500@nortel.com> (raw)
In-Reply-To: <20080929100227.GA21129@amitarora.in.ibm.com>

Amit K. Arora wrote:
> Hello,
> 
> Please consider this patch. It makes a few minor changes to
> sched_fair.c.
> 
> 
> sched: Minor optimizations in wake_affine and select_task_rq_fair
> 
> This patch does following:
> o Reduces the number of arguments to wake_affine().

At what point is it cheaper to pass items as args rather than 
recalculating them?  If reducing the number of args is desirable, what 
about removing the "this_cpu" and "prev_cpu" args and recalculating them 
in wake_affine()?

Chris

  reply	other threads:[~2008-09-29 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 10:02 [PATCH] sched: minor optimizations in wake_affine and select_task_rq_fair Amit K. Arora
2008-09-29 16:09 ` Chris Friesen [this message]
2008-09-30  7:01   ` Ingo Molnar
2008-09-30 11:40     ` Amit K. Arora
2008-09-30  7:03   ` Amit K. Arora
2008-09-30 11:45 ` [PATCH][resubmit] " Amit K. Arora
2008-09-30 13:26   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E0FDC5.1080500@nortel.com \
    --to=cfriesen@nortel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aarora@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.