From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Subject: Re: [PATCH 0/5] [RFC] ALSA ASoC Support for TLVaic23b audio codec Date: Mon, 29 Sep 2008 10:27:06 -0700 Message-ID: <48E10FEA.7000300@boundarydevices.com> References: <48E1068E.7020908@boundarydevices.com> <20080929165404.GA16109@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtpauth01.csee.onr.siteprotect.com (smtpauth01.csee.onr.siteprotect.com [64.26.60.145]) by alsa0.perex.cz (Postfix) with ESMTP id 74626244AF for ; Mon, 29 Sep 2008 19:27:23 +0200 (CEST) In-Reply-To: <20080929165404.GA16109@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Arun KS List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > On Mon, Sep 29, 2008 at 09:47:10AM -0700, Troy Kisky wrote: > >> Great. I just finished the same thing for davinci but using spi. >> I was waiting until the adc issue I mentioned yesterday was resolved before posting it. >> I'm glad I won't have to now. But my board also has I2c, just not with this > > It'd be great if you could work with Arun to ensure that all the > features which you are using are supported in the driver - it looks like > at least SPI support will need to be added. > >> codec. Can the I2c code be moved into the board directory? I have my spi code >> in the board directory and just pass the write function pointer. i.e. > > No, the I2C and SPI support should both be part of the driver. The > driver should just be modified to allow both I2C and SPI support to be > compiled in and let the board driver register the appropriate one at run > time. > Can you please explain to me why they should both be part of the codec driver? Thanks Troy