All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Haley <brian.haley@hp.com>
To: Simon Horman <horms@verge.net.au>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
	Vlad Yasevich <vladislav.yasevich@hp.com>,
	Alex Sidorenko <alexandre.sidorenko@hp.com>,
	Jeff Garzik <jeff@garzik.org>,
	netdev@vger.kernel.org
Subject: Re: [RFC] bonding: add better ipv6 failover support
Date: Wed, 01 Oct 2008 09:24:08 -0400	[thread overview]
Message-ID: <48E379F8.7090403@hp.com> (raw)
In-Reply-To: <20081001055355.GA27304@verge.net.au>

Hi Simon,

Simon Horman wrote:
> I took a bit of a stab at this, and here is what I cam up with.
> 
> It should enable IPV6_BONDING if one of the following is true
>   * EXPERIMENTAL=y && IPV6=m && BONDING=m
>   * EXPERIMENTAL=y && IPV6=y && BONDING=m
>   * EXPERIMENTAL=y && IPV6=y && BONDING=y
> And disable IPV6_BONDING in all other cases.
> 
> Compile tested only.
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 69c81da..60c06f8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -61,6 +61,7 @@ config DUMMY
>  config BONDING
>  	tristate "Bonding driver support"
>  	depends on INET
> +	select IPV6_BONDING if (IPV6=y || IPV6=BONDING) && EXPERIMENTAL
>  	---help---
>  	  Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet
>  	  Channels together. This is called 'Etherchannel' by Cisco,
> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index ec99215..49108be 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -217,4 +217,7 @@ config IPV6_PIMSM_V2
>  	  Support for IPv6 PIM multicast routing protocol PIM-SMv2.
>  	  If unsure, say N.
>  
> +config IPV6_BONDING
> +	bool
> +
>  endif # IPV6

I actually figured out how to do this without having a new Kconfig 
option at all, and building bonding_ipv6.c without getting a linker 
error.  I'll send out an updated patch soon, just sorting out the vlan 
support right now.

Thanks,

-Brian

  reply	other threads:[~2008-10-01 13:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-15 17:35 Bonding and Neighbour Discovery on IPv6-only devices Alex Sidorenko
2008-09-15 18:00 ` Jeff Garzik
2008-09-15 18:16   ` Jay Vosburgh
2008-09-15 18:16   ` Alex Sidorenko
2008-09-24 16:58     ` Vlad Yasevich
2008-09-24 20:29       ` Jay Vosburgh
2008-09-24 21:07         ` Brian Haley
2008-09-25  2:46         ` [RFC] bonding: add better ipv6 failover support Brian Haley
2008-09-25 15:07           ` Jay Vosburgh
2008-09-25 15:42             ` Brian Haley
2008-10-01  5:53               ` Simon Horman
2008-10-01 13:24                 ` Brian Haley [this message]
2008-10-01 13:36                   ` David Miller
2008-09-26 18:51           ` David Stevens
2008-09-26 19:09             ` Jay Vosburgh
2008-09-26 19:28             ` Brian Haley
2008-09-26 19:55               ` Vlad Yasevich
2008-09-26 19:46             ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E379F8.7090403@hp.com \
    --to=brian.haley@hp.com \
    --cc=alexandre.sidorenko@hp.com \
    --cc=fubar@us.ibm.com \
    --cc=horms@verge.net.au \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladislav.yasevich@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.