From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: 11/11 [NETFILTER]: Remove redundant casts from Ebtables extensions
Date: Thu, 02 Oct 2008 12:37:39 +0200 [thread overview]
Message-ID: <48E4A473.9080307@trash.net> (raw)
In-Reply-To: <48E4A2C4.5050503@trash.net>
Patrick McHardy wrote:
> Jan Engelhardt wrote:
>> commit 07f89c4687ada3347c454fc8ff2d078256019eb6
>> Author: Jan Engelhardt <jengelh@medozas.de>
>> Date: Wed Sep 10 22:39:32 2008 -0400
>>
>> [NETFILTER]: Remove redundant casts from Ebtables extensions
>>
>
> Also applied, thanks Jan.
This patch introduces new warnings because data is const:
@@ -20,7 +20,7 @@ ebt_arpreply_tg(struct sk_buff *skb, const struct net_device *in,
const struct net_device *out, unsigned int hook_nr,
const struct xt_target *target, const void *data)
{
- struct ebt_arpreply_info *info = (void *)data;
+ struct ebt_arpreply_info *info = data;
I'm backing it out for now, please resend with the private structs changed
to const (if possible).
next prev parent reply other threads:[~2008-10-02 10:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 2:44 01/11 [NETFILTER]: Ebtables: do centralized size checking Jan Engelhardt
2008-09-11 2:44 ` 02/11 [NETFILTER]: Change return types of check functions for Ebtables extensions Jan Engelhardt
2008-10-02 10:15 ` Patrick McHardy
2008-09-11 2:45 ` 03/11 [NETFILTER]: Change return types of match " Jan Engelhardt
2008-10-02 10:18 ` Patrick McHardy
2008-09-11 2:45 ` 04/11 [NETFILTER]: Change return types of targets/watchers " Jan Engelhardt
2008-10-02 10:20 ` Patrick McHardy
2008-09-11 2:45 ` 05/11 [NETFILTER]: Add dummy members to Ebtables code to ease transition to Xtables Jan Engelhardt
2008-10-02 10:21 ` Patrick McHardy
2008-09-11 2:45 ` 06/11 [NETFILTER]: ebt_among: obtain match size through different means Jan Engelhardt
2008-10-02 10:22 ` Patrick McHardy
2008-09-11 2:45 ` 07/11 [NETFILTER]: Change Ebtables function signatures to match Xtables's Jan Engelhardt
2008-10-02 10:23 ` Patrick McHardy
2008-09-11 2:45 ` 08/11 [NETFILTER]: Move Ebtables to use Xtables Jan Engelhardt
2008-10-02 10:27 ` Patrick McHardy
2008-09-11 2:45 ` 09/11 [NETFILTER]: Implement hotdrop for Ebtables Jan Engelhardt
2008-10-02 10:28 ` Patrick McHardy
2008-10-02 10:29 ` Patrick McHardy
2008-09-11 2:46 ` 10/11 [NETFILTER]: Remove unused Ebtables functions Jan Engelhardt
2008-10-02 10:29 ` Patrick McHardy
2008-09-11 2:46 ` 11/11 [NETFILTER]: Remove redundant casts from Ebtables extensions Jan Engelhardt
2008-10-02 10:30 ` Patrick McHardy
2008-10-02 10:37 ` Patrick McHardy [this message]
2008-10-03 13:35 ` Jan Engelhardt
2008-10-02 10:10 ` 01/11 [NETFILTER]: Ebtables: do centralized size checking Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E4A473.9080307@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.