Re: [PATCH] provide a kvm_qemu_memory_alias() function

[Avi Kivity <avi@redhat.com>]

Glauber Costa wrote:
> On Wed, Oct 1, 2008 at 4:38 AM, Avi Kivity <avi@redhat.com> wrote:
>   
>> Glauber Costa wrote:
>>     
>>> Following the pattern we already do, provide a qemu_kvm wrapper to
>>> the memory aliases x86 functions. Reason is that we don't want to have
>>> references to the context spread over qemu.
>>>
>>> The destroy alias function is completely removed from libkvm/libkvm.c,
>>> since no one in the code base uses it directly.
>>>
>>>  -int kvm_destroy_memory_alias(kvm_context_t kvm, uint64_t phys_start)
>>> -{
>>> -       return kvm_create_memory_alias(kvm, phys_start, 0, 0);
>>> -}
>>> -
>>>
>>>       
>> This exists so that readers don't have to wander why you're calling
>> kvm_create_memory_alias when you actually want to destroy one.
>>     
>
> So what? I'm replacing it with a kvm_qemu_destroy... that does the
> very same thing, in the very same way.
> only difference is the presence/absence of context.
>   

libkvm exists to provide a sane API to applications.  Using 
kvm_create_memory_alias() to destroy aliases is not a sane API.


-- 
error compiling committee.c: too many arguments to function