All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] format-patch: autonumber by default
Date: Thu, 02 Oct 2008 15:43:09 +0200	[thread overview]
Message-ID: <48E4CFED.3060903@op5.se> (raw)
In-Reply-To: <cb7bb73a0810020610q657dec7clf85b4ef3575b751f@mail.gmail.com>

Giuseppe Bilotta wrote:
> On Thu, Oct 2, 2008 at 2:33 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> Hi,
>>
>> On Thu, 2 Oct 2008, Giuseppe Bilotta wrote:
>>
>>> Set auto-number true by default, allowing the format.number key to be
>>> set to 'noauto' to override this.
>>> ---
>>>  builtin-log.c |    6 +++++-
>>>  1 files changed, 5 insertions(+), 1 deletions(-)
>> Interesting.  No sign-off, no defense why this is actually desirable,
>> after we lived for so long without this behavior... Care to elaborate?
> 
> Doh, sorry about the Sign-off, I'll resend with.
> 
> Now, about the reason for this patch: I would say that the most common
> use-case of format-patch being used to prepare multiple patches is
> when one plans on sending a patchset. When format.numbering is set to
> auto, single-patches will still be extracted without numbers, but
> patchset will be properly numbered.
> 

I like it. It hasn't bitten me since I moved to imap-send, but when I
used send-email I sometimes forgot and ended up sending patch-series
without numbers.

I sent a patch for it once, but changed the default instead of making
it configurable so it got turned down.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  parent reply	other threads:[~2008-10-02 13:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 11:27 [PATCH] format-patch: autonumber by default Giuseppe Bilotta
2008-10-02 12:33 ` Johannes Schindelin
2008-10-02 13:10   ` Giuseppe Bilotta
2008-10-02 13:42     ` Johannes Schindelin
2008-10-02 13:47       ` Giuseppe Bilotta
2008-10-02 14:08         ` Jakub Narebski
2008-10-02 14:14           ` Andreas Ericsson
2008-10-02 17:58             ` Giuseppe Bilotta
2008-10-02 20:03               ` Jeff King
2008-10-02 20:15                 ` Giuseppe Bilotta
2008-10-02 21:06                   ` Jeff King
2008-10-02 20:17               ` Brian Gernhardt
2008-10-02 20:36                 ` Brian Gernhardt
2008-10-02 20:41                 ` Brian Gernhardt
2008-10-02 20:50                   ` Brian Gernhardt
2008-10-02 20:55                 ` [PATCH v2] " Brian Gernhardt
2009-11-04 11:20                   ` Eric W. Biederman
2009-11-04 17:38                     ` Junio C Hamano
2009-11-04 17:48                     ` Brian Gernhardt
2008-10-02 13:43     ` Andreas Ericsson [this message]
2008-10-02 13:54     ` [PATCH] " Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E4CFED.3060903@op5.se \
    --to=ae@op5.se \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.