From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "\"J.A. Magallón\"" <jamagallon@ono.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
"Yinghai Lu" <yinghai@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M
Date: Fri, 03 Oct 2008 00:40:15 -0700 [thread overview]
Message-ID: <48E5CC5F.4020300@zytor.com> (raw)
In-Reply-To: <20081003073727.GC4950@elte.hu>
Ingo Molnar wrote:
>
>> +++ arch/x86/kernel/cpu/mtrr/if.c 2008-10-03 00:22:34.000000000 +0200
>> @@ -16,7 +16,7 @@
>> static const char *const mtrr_strings[MTRR_NUM_TYPES] =
>> {
>> "uncachable", /* 0 */
>> - "write-combining", /* 1 */
>> + "write-combine", /* 1 */
>
> hm, maybe this bit could confuse versions of Xorg that modifies
> /proc/mtrr - i.e. this could be part of the ABI towards user-space.
> We'll see.
>
By the way, this is just plain wrong; the cachability name is "Write
Combining (WC)" not "write-combine".
-hpa
next prev parent reply other threads:[~2008-10-03 7:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 1:54 [PATCH 1/2] x86: mtrr_cleanup prepare to make gran_size to less 1M Yinghai Lu
2008-09-30 1:54 ` [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M Yinghai Lu
2008-10-02 22:03 ` J.A. Magallón
2008-10-02 22:33 ` Yinghai Lu
2008-10-02 22:52 ` Yinghai Lu
2008-10-02 23:00 ` J.A. Magallón
2008-10-02 23:20 ` Yinghai Lu
2008-10-02 22:58 ` J.A. Magallón
2008-10-02 23:55 ` D. Hugh Redelmeier
2008-10-03 1:27 ` Yinghai Lu
2008-10-02 22:32 ` J.A. Magallón
2008-10-02 22:39 ` Yinghai Lu
2008-10-02 22:46 ` Yinghai Lu
2008-10-03 7:38 ` Ingo Molnar
2008-10-02 23:20 ` J.A. Magallón
2008-10-02 23:45 ` Yinghai Lu
2008-10-03 7:37 ` Ingo Molnar
2008-10-03 7:38 ` H. Peter Anvin
2008-10-03 7:42 ` Ingo Molnar
2008-10-03 7:44 ` H. Peter Anvin
2008-10-03 14:57 ` D. Hugh Redelmeier
2008-10-03 7:40 ` H. Peter Anvin [this message]
2008-10-03 7:44 ` Ingo Molnar
2008-10-03 7:41 ` J.A. Magallón
2008-09-30 4:07 ` [PATCH 1/2] x86: mtrr_cleanup prepare to make gran_size to less 1M H. Peter Anvin
2008-09-30 7:45 ` Ingo Molnar
2008-09-30 8:11 ` Ingo Molnar
2008-09-30 16:06 ` Yinghai Lu
2008-09-30 18:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E5CC5F.4020300@zytor.com \
--to=hpa@zytor.com \
--cc=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.