From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Martin Schwenke <martin@meltin.net>, netfilter-devel@vger.kernel.org
Subject: Re: iptables not working with monolithic 2.6.26.5 kernel on ARM
Date: Sun, 05 Oct 2008 16:05:55 +0200 [thread overview]
Message-ID: <48E8C9C3.8080303@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0810050955560.21891@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Sunday 2008-10-05 09:24, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> You can change the XT_ALIGN macro in the
>>> kernel/include/linux/netfilter/x_tables.h and
>>> iptables/include/linux/netfilter/x_tables.h to read
>>>
>>> #ifndef roundup
>>> #define roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y))
>>> #endif
>>> #define XT_ALIGN(s) roundup(s, sizeof(uint64_t))
>>>
>>> and try again. There might be more alignment issues hiding, so
>>> don't expect it to fix it all in a magic whizz.
>> An idea to avoid these problems in the future would be to change
>> the kernel so it accepts stricter alignment than what we currently
>> use and after a grace period (maybe 1-2 years) change XT_ALIGN in
>> userspace so it starts using u64 or simply 8 byte alignment
>> everywhere.
>
> I'd rather be interested in what architectures actually have
> alignof(uint64_t) == 4, besides the native ARM gcc that's used here.
CRIS isn't requiring any alignment AFAIK, so everything is just
byte aligned. I don't know about any other architectures not
using 8 byte alignment.
next prev parent reply other threads:[~2008-10-05 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 4:42 iptables not working with monolithic 2.6.26.5 kernel on ARM Martin Schwenke
2008-10-03 12:56 ` Patrick McHardy
2008-10-03 14:10 ` Jan Engelhardt
2008-10-04 4:21 ` Martin Schwenke
2008-10-04 11:49 ` Jan Engelhardt
2008-10-05 13:24 ` Patrick McHardy
2008-10-05 14:01 ` Jan Engelhardt
2008-10-05 14:05 ` Patrick McHardy [this message]
2008-10-06 1:34 ` Martin Schwenke
2008-10-06 1:40 ` Jan Engelhardt
2008-10-06 3:02 ` Martin Schwenke
2008-10-06 3:17 ` Jan Engelhardt
2008-10-06 10:09 ` Martin Schwenke
2008-10-05 13:21 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E8C9C3.8080303@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=martin@meltin.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.