From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [NETFILTER]: Move extensions' arguments into compound structure (1/2) Date: Sun, 05 Oct 2008 17:12:23 +0200 Message-ID: <48E8D957.3000803@trash.net> References: <48E8CF70.9090309@trash.net> <48E8D493.5@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:46973 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbYJEPM3 (ORCPT ); Sun, 5 Oct 2008 11:12:29 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Sunday 2008-10-05 10:52, Patrick McHardy wrote: >> Reducing the overhead before merging will make me a lot more >> comfortable accepting this patch without seeing any numbers >> since its adding overhead to one of the hottest spots of ruleset >> evaluation. >> > Ok just let me rebase all the stuff, and I'll send you something > that goes on top of 8d51a66159a6fbc27342ee80e5b69910a679735e . Thanks. As an added explanation - the benchmarking I did for nftables indicated that we're somewhere between 50 and 110 cycles for a "usual" rule on my x2. So its really easy to degrade performance significantly by just requiring a few more cycles. The upside is that it works in both directions :) >>> Yup. When space is tight (and we only have like 74 chars to make it >>> fit onto a screen, accounting for the git-log indent and one extra >>> byte), it will have to do without the subsystem. >> No, I'm adding it anyways and exceeding the limit is fine for >> changelogs if it aids in readability. So please just add it so >> I don't have to edit the descriptions every time. > > Aye, sir! Thanks.