From: Wolfgang Grandegger <wg@grandegger.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: w83781d: make ISA interface
Date: Mon, 06 Oct 2008 13:32:44 +0000 [thread overview]
Message-ID: <48EA137C.4050903@grandegger.com> (raw)
In-Reply-To: <48CB7F6D.8010109@grandegger.com>
Hi Jean,
Jean Delvare wrote:
> Hi Wolfgang,
>
> On Sat, 13 Sep 2008 10:53:01 +0200, Wolfgang Grandegger wrote:
>> Probing the ISA bus on systems without ISA bus may hang the system.
>> This patch makes the ISA bus related code depend on the kernel
>> configuration parameter CONFIG_ISA. It moves ISA bus related code
>> into one #ifdef CONFIG_ISA ... #endif block and adds some helper
>> function.
>
> As said before, this patch is a little bigger than I hoped for, but I
> admit it nicely optimizes the size of the driver when CONFIG_ISA isn't
> set. So, so be it, I'm taking it.
Well, the code was not written with separating the ISA interface in mind
and I'm only partially happy with it, to say the least.
>> Note that this patch is based on the patches:
>>
>> hwmon-w83781d-01-refactor-beep-enable.patch
>> hwmon-w83781d-02-alias-detect.patch
>>
>> from http://jdelvare.pck.nerim.net/sensors/w83781d/.
OK, great, thanks.
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>> ---
>> drivers/hwmon/w83781d.c | 666 +++++++++++++++++++++++++++---------------------
>> 1 file changed, 388 insertions(+), 278 deletions(-)
>>
>> Index: linux-2.6-denx/drivers/hwmon/w83781d.c
>> =================================>> --- linux-2.6-denx.orig/drivers/hwmon/w83781d.c
>> +++ linux-2.6-denx/drivers/hwmon/w83781d.c
>> @@ -49,14 +49,9 @@
>> #include <asm/io.h>
>> #include "lm75.h"
>
> You can put the inclusion of <linux/platform_device.h>,
> <linux/ioport.h> and <asm/io.h> inside #ifdef CONFIG_ISA as well. This
> will avoid unneeded rebuilds.
Fine for me.
[...deletions...]
>> +static void __init
>
> Should be __exit not __init.
Oops, sorry.
> In order to save some time, I've fixed all these minor issues myself.
>
> Patch tested on my system with an ISA chip and it worked fine. I will
> test later with a graphics adapter with a W83781D chip on the same
> system.
Thanks a lot.
Wolfgang.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2008-10-06 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 8:53 [lm-sensors] [PATCH 1/2] hwmon: w83781d: make ISA interface depend Wolfgang Grandegger
2008-10-06 13:13 ` [lm-sensors] [PATCH 1/2] hwmon: w83781d: make ISA interface Jean Delvare
2008-10-06 13:32 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EA137C.4050903@grandegger.com \
--to=wg@grandegger.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.