From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: righi.andrea@gmail.com, agk@sourceware.org,
akpm@linux-foundation.org, axboe@kernel.dk,
baramsori72@gmail.com, Carl Henrik Lunde <chlunde@ping.uio.no>,
dave@linux.vnet.ibm.com, Divyesh Shah <dpshah@google.com>,
eric.rannaud@gmail.com, fernando@oss.ntt.co.jp,
Hirokazu Takahashi <taka@valinux.co.jp>,
Li Zefan <lizf@cn.fujitsu.com>,
Marco Innocenti <m.innocenti@cineca.it>,
matt@bluehost.com, ngupta@google.com, randy.dunlap@oracle.com,
roberto@unbit.it, Ryo Tsuruta <ryov@valinux.co.jp>,
Satoshi UCHIDA <s-uchida@ap.jp.nec.com>,
subrata@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 2/6] introduce struct res_counter_ratelimit
Date: Mon, 06 Oct 2008 22:50:02 +0530 [thread overview]
Message-ID: <48EA48C2.40803@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830810061014q5535b5b6kfb53182b3fcc60c8@mail.gmail.com>
Paul Menage wrote:
> On Mon, Oct 6, 2008 at 1:03 AM, Andrea Righi <righi.andrea@gmail.com> wrote:
>>> Could you not either:
>>>
>>> - include these two extra fields in res_counter?
>>> - include res_counter as the first field in a res_counter_ratelimit?
>> The second solution would save some space if the "ratelimit" part is not used.
>
> Having a "policy" field in res_counter seems like it might be reusable
> as something for other non-ratelimited res_counters. And even if it's
> not, the memory overhead of a couple of extra fields in a res_counter
> is trivial compared to the overhead of resource isolation anyway.
>
> So my first approach to this would be just extend res_counter, and
> then split them apart later if it turns out that they really do need
> mutually incompatible code/handlers.
Yes! I agree
--
Balbir
next prev parent reply other threads:[~2008-10-06 17:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 11:05 [PATCH -mm 2/6] introduce struct res_counter_ratelimit Andrea Righi
2008-09-17 11:05 ` Andrea Righi
[not found] ` <1221649528-8519-3-git-send-email-righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-09-19 17:08 ` Randy Dunlap
2008-09-19 17:08 ` Randy Dunlap
[not found] ` <20080919100832.e188460a.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-09-19 20:32 ` Andrea Righi
2008-09-19 20:32 ` Andrea Righi
2008-10-05 18:03 ` Paul Menage
2008-10-05 18:03 ` Paul Menage
2008-10-06 8:03 ` Andrea Righi
2008-10-06 17:14 ` Paul Menage
2008-10-06 17:20 ` Balbir Singh [this message]
2008-10-06 19:38 ` Andrea Righi
[not found] ` <48EA48C2.40803-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-10-06 19:38 ` Andrea Righi
[not found] ` <6599ad830810061014q5535b5b6kfb53182b3fcc60c8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-10-06 17:20 ` Balbir Singh
[not found] ` <48E9C637.8030507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-10-06 17:14 ` Paul Menage
[not found] ` <6599ad830810051103v1bd6e8d4xd2fcf622558fc7d9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-10-06 8:03 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EA48C2.40803@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=agk@sourceware.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=baramsori72@gmail.com \
--cc=chlunde@ping.uio.no \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=dpshah@google.com \
--cc=eric.rannaud@gmail.com \
--cc=fernando@oss.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=m.innocenti@cineca.it \
--cc=matt@bluehost.com \
--cc=menage@google.com \
--cc=ngupta@google.com \
--cc=randy.dunlap@oracle.com \
--cc=righi.andrea@gmail.com \
--cc=roberto@unbit.it \
--cc=ryov@valinux.co.jp \
--cc=s-uchida@ap.jp.nec.com \
--cc=subrata@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.