From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 14/17] qemu: x86: Debug register emulation
Date: Tue, 07 Oct 2008 14:15:13 +0200 [thread overview]
Message-ID: <48EB52D1.3020204@redhat.com> (raw)
In-Reply-To: <20081006091417.670837853@mchn012c.ww002.siemens.net>
Jan Kiszka wrote:
> Built on top of previously enhanced breakpoint/watchpoint support, this
> patch adds full debug register emulation for the x86 architecture.
>
> Many corner cases were considered, and the result was successfully
> tested inside a Linux guest with gdb, but I won't be surprised if one
> or two scenarios still behave differently in reality.
>
> +
> +static inline int hw_breakpoint_len(unsigned long dr7, int index)
> +{
> + return ((dr7 >> (DR7_LEN_SHIFT + (index * 2))) & 3) + 1;
> +}
> +
>
A len encoding of 2 means an 8-byte breakpoint.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-07 12:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 9:14 [PATCH 00/17] kvm-userspace: Fix and improve guest debugging and x86 debug registers Jan Kiszka
2008-10-06 9:14 ` [PATCH 01/17] kvm-userspace: Remove old guest debugging hooks Jan Kiszka
2008-10-06 9:14 ` [PATCH 02/17] qemu: Return appropriate watch message to gdb Jan Kiszka
2008-10-06 9:14 ` [PATCH 03/17] qemu: Refactor and enhance break/watchpoint API Jan Kiszka
2008-10-06 9:14 ` [PATCH 04/17] qemu: Set mem_io_vaddr on io_read Jan Kiszka
2008-10-06 9:14 ` [PATCH 05/17] qemu: Respect length of watchpoints Jan Kiszka
2008-10-07 12:04 ` Avi Kivity
2008-10-08 20:22 ` Jan Kiszka
2008-10-06 9:14 ` [PATCH 06/17] qemu: Introduce next_cflags Jan Kiszka
2008-10-07 12:07 ` Avi Kivity
2008-10-06 9:14 ` [PATCH 07/17] qemu: Switch self-modified code recompilation to next_cflags Jan Kiszka
2008-10-06 9:14 ` [PATCH 08/17] qemu: Restore pc on watchpoint hits - v3 Jan Kiszka
2008-10-06 9:14 ` [PATCH 09/17] qemu: Remove premature memop TB terminations Jan Kiszka
2008-10-06 9:14 ` [PATCH 10/17] qemu: Improve debugging of SMP guests Jan Kiszka
2008-10-07 12:12 ` Avi Kivity
2008-10-08 20:25 ` Jan Kiszka
2008-10-06 9:14 ` [PATCH 11/17] qemu: Introduce BP_WATCHPOINT_HIT flag Jan Kiszka
2008-10-06 9:14 ` [PATCH 12/17] qemu: Add debug exception hook Jan Kiszka
2008-10-06 9:14 ` [PATCH 13/17] qemu: Introduce BP_CPU as a breakpoint type Jan Kiszka
2008-10-06 9:14 ` [PATCH 14/17] qemu: x86: Debug register emulation Jan Kiszka
2008-10-07 12:15 ` Avi Kivity [this message]
2008-10-08 20:25 ` Jan Kiszka
2008-10-06 9:14 ` [PATCH 15/17] kvm-userspace: Switch to new guest debug interface Jan Kiszka
2008-10-06 9:14 ` [PATCH 16/17] kvm-userspace: Provide compat wrapper for set_debugreg Jan Kiszka
2008-10-07 12:17 ` Avi Kivity
2008-10-08 20:25 ` Jan Kiszka
2008-10-06 9:14 ` [PATCH 17/17] kvm-userspace: remove obsolete special_reload_dr7 hack Jan Kiszka
2008-10-07 12:18 ` [PATCH 00/17] kvm-userspace: Fix and improve guest debugging and x86 debug registers Avi Kivity
2008-10-07 12:20 ` Jan Kiszka
2008-11-17 22:44 ` Markus Armbruster
2008-11-18 9:08 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB52D1.3020204@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.