From: Frank Myhr <fmyhr@fhmtech.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] Allow it87.c to handle IT8720
Date: Tue, 07 Oct 2008 13:55:29 +0000 [thread overview]
Message-ID: <48EB6A51.2040101@fhmtech.com> (raw)
In-Reply-To: <79c9d4530810061031v77c2b2afo983cdef4ca6bc71e@mail.gmail.com>
Hi Jean-Marc,
Your patch looks good to me with a few niggles:
> To:
> LKML <linux-kernel@vger.kernel.org>, "LM Sensors"
> <lm-sensors@lm-sensors.org>
I don't know if it's necessary/recommended to submit directly to LKML in
addition to the lm-sensors list. (Maybe somebody else can comment on that.)
> The goal of this patch is to allow it87.c to handle IT8720 chipset
> like IT8718 in order to retreive voltage, temperatures and fans speed
> from sensors tools.
>
> JMS
>
> Patch also attached.
Good description but the "Patch also attached" is superfluous; your
[PATCH] subject line already says that. I believe these comments are
copied verbatim into the kernel git changelog, so it's important to keep
them succinct.
More importantly, you need to sign your patch with:
Signed-off-by: [your real name] [your email address]
---
> --- linux-2.6.27-rc8/drivers/hwmon/it87.c.orig 2008-10-02
> 09:04:44.000000000 -0400
> +++ linux-2.6.27-rc8/drivers/hwmon/it87.c 2008-10-06
> 13:27:08.000000000 -0400
Please make sure your mailer is not wrapping lines, it looks here like
it is.
Regards,
-Frank
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-10-07 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 17:31 [lm-sensors] [PATCH] Allow it87.c to handle IT8720 Jean-Marc Spaggiari
2008-10-06 17:33 ` Jean-Marc Spaggiari
2008-10-06 17:33 ` Jean-Marc Spaggiari
2008-10-07 20:36 ` [lm-sensors] " Jean Delvare
2008-10-07 20:36 ` Jean Delvare
2008-10-22 9:59 ` Jean Delvare
2008-10-22 9:59 ` Jean Delvare
2008-10-07 13:55 ` Frank Myhr [this message]
2008-10-07 20:21 ` Jean Delvare
2008-10-22 12:11 ` Jean-Marc Spaggiari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB6A51.2040101@fhmtech.com \
--to=fmyhr@fhmtech.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.