All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Anderson <anderson@redhat.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com,
	"Discussion list for crash utility usage,
	maintenance and development" <crash-utility@redhat.com>
Subject: Re: Re: [Crash-utility] xencrash fixes for xen-3.3.0
Date: Tue, 07 Oct 2008 10:35:37 -0400	[thread overview]
Message-ID: <48EB73B9.7000004@redhat.com> (raw)
In-Reply-To: <C51128C4.1DF04%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> On 7/10/08 14:39, "Dave Anderson" <anderson@redhat.com> wrote:
> 
>> The patch looks OK.  But just for sanity's sake, is it guaranteed that
>> the per_cpu data section will be greater than 4k on both architectures?
>> Or could there be some combination of xen CONFIG options that could
>> reduce the i386 per_cpu data section contents to less than 4K even though
>> PERCPU_SHIFT is 13?
> 
> PERCPU_SHIFT has only ever been 12 or 13 so far, and it's unlikely to ever
> get smaller. Ongoing, we could help you out by defining some useful label in
> our linker script. For example, __per_cpu_shift = PERCPU_SHIFT (or
> '__per_cpu_start + PERCPU_SHIFT', as I'm not sure about creating labels
> outside the virtual address ranges defined by the object file).
> 
>  -- Keir

Yep, that's fine too, but for now Oda-san's patch will suffice now as
long as the smallest possible percpu data section on the x86 arch with
a PERCPU_SHIFT of 13 will always overflow into a space greater than 4k.
So I'm still curious, because I note that on a RHEL5 x86_64 hypervisor
the per-cpu data space is 1576 bytes, and presumably smaller on an x86.
Was there a new data structure that forced the issue?  And does it force
the issue on both arches?

Dave

  reply	other threads:[~2008-10-07 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-07  1:33 xencrash fixes for xen-3.3.0 Itsuro ODA
2008-10-07 13:39 ` [Crash-utility] " Dave Anderson
2008-10-07 13:55   ` Keir Fraser
2008-10-07 14:35     ` Dave Anderson [this message]
2008-10-07 15:01       ` Keir Fraser
2008-10-07 22:39     ` Itsuro ODA
2008-10-07 22:33   ` Itsuro ODA
     [not found]     ` <1121070190.1542151223470607358.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com>
2008-10-09  7:08       ` Itsuro ODA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EB73B9.7000004@redhat.com \
    --to=anderson@redhat.com \
    --cc=crash-utility@redhat.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.