From: Steven Toth <stoth@linuxtv.org>
To: Jose Alberto Reguero <jareguero@telefonica.net>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] Problems with new S2API and DVB-T
Date: Tue, 07 Oct 2008 10:44:30 -0400 [thread overview]
Message-ID: <48EB75CE.30107@linuxtv.org> (raw)
In-Reply-To: <200810071134.06020.jareguero@telefonica.net>
Jose Alberto Reguero wrote:
> El Martes, 7 de Octubre de 2008, Steven Toth escribió:
>> Jose Alberto Reguero wrote:
>>> I am trying to use the new API for DVB-T and I have some problems. They
>>> are not way to set code_rate_HP, code_rate_LP, transmission_mode, and
>>> guard_interval , and the default values are 0, that are not the AUTO
>>> ones. Also the bandwidth is not treated well. The attached patch is a
>>> workaround that works for me.
>> Hi Jose,
>>
>> Thanks for your patch.
>>
>> I've taken a different approach and added support for
>> DTV_TRANSMISSION_MODE, DTV_HIERARCHY, DTV_GUARD_INTERVAL,
>> DTV_CODE_RATE_HP and DTV_CODE_RATE_LP, so this will probably help.
>>
>> In terms of the bandwidth changes, you realise that you have to
>> bandwidth in units of HZ via the S2API? If you're doing this then I do
>> not see why the bandwidth code is failing. We have some backward compat
>> code which should be cleanly taking care of this, proving you pass HZ
>> into the S2API.
>>
>> One interest point is that we may want to pick sensible defaults for the
>> cache values during initialisation (which doesn't currently happen).
>> Applications that rely on default behaviour could be failing... although
>> Kaffeine, Myth, VDR and tzap applications are not experiencing this issue.
>>
>> http://linuxtv.org/hg/~stoth/s2
>>
>> Could you pull this tree and try again? (Remember to change your
>> bandwidth values to HZ, I.e. 8000000.
>>
>> Thanks again,
>>
>> Steve
>
> It works ok.
> Thanks.
Thanks for testing Jose, regards.
- Steve
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
prev parent reply other threads:[~2008-10-07 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 12:22 [linux-dvb] Problems with new S2API and DVB-T Jose Alberto Reguero
2008-10-07 1:06 ` Steven Toth
2008-10-07 9:34 ` Jose Alberto Reguero
2008-10-07 14:44 ` Steven Toth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB75CE.30107@linuxtv.org \
--to=stoth@linuxtv.org \
--cc=jareguero@telefonica.net \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.