All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: John Linville <linville@tuxdriver.com>,
	Johannes Berg <johannes@sipsolutions.net>, Chr <chunkeey@web.de>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] p54: Fix compilation problem on PPC
Date: Tue, 07 Oct 2008 08:27:45 -0700	[thread overview]
Message-ID: <48EB7FF1.9060803@lwfinger.net> (raw)

The commit entitled "p54: Fix sparse warnings" introduced a compile
error on PPC architecture. Thanks to Johannes Berg
<johannes@sipsolutions.net> for reporting this problem.

Signed-off-by: <Larry.Finger@lwfinger.net>
---

John,

This is 2.6.28 material. I hope this comes through OK. I don't have
access to my usual way of submitting patches.

Larry
---

Johannes,

Do you have access to a p54 device, or were you just compile testing?
In my mind, there is still a big question regarding the endianness of
one of the data arrays.

Larry
---

Index: wireless-testing/drivers/net/wireless/p54/p54common.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/p54/p54common.c
+++ wireless-testing/drivers/net/wireless/p54/p54common.c
@@ -482,7 +482,6 @@ static int p54_parse_eeprom(struct ieee8
 	printk(KERN_ERR "p54: eeprom parse failed!\n");
 	return err;
 }
-EXPORT_SYMBOL_GPL(p54_parse_eeprom);

 static int p54_rssi_to_dbm(struct ieee80211_hw *dev, int rssi)
 {


             reply	other threads:[~2008-10-07 15:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-07 15:27 Larry Finger [this message]
2008-10-07 16:57 ` [PATCH] p54: Fix compilation problem on PPC Johannes Berg
2008-10-07 23:56   ` Larry Finger
2008-10-08  0:14   ` Pavel Roskin
2008-10-08 17:03     ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EB7FF1.9060803@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chunkeey@web.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.