From: Christoph Lameter <cl@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH next 1/3] slub defrag: unpin writeback pages
Date: Tue, 07 Oct 2008 10:41:08 -0500 [thread overview]
Message-ID: <48EB8314.1030701@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0810071606530.32764@blonde.site>
Hugh Dickins wrote:
> But since the cacheline is already dirty (from get_page_unless_zero),
> and it's only a trylock, and we (almost certainly) need to repeat the
> PageWriteback test once we've got the lock, and it does not hit this
> case often enough for you to have noticed the missing put_page() bug,
> I decided to save icache instead by just removing your optimization.
Ok. Acked-by: Christoph Lameter <cl@linux-foundation.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-10-07 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-05 2:25 [PATCH next 1/3] slub defrag: unpin writeback pages Hugh Dickins
2008-10-05 2:27 ` [PATCH next 2/3] slub defrag: dma_kmalloc_cache add_tail Hugh Dickins
2008-10-06 7:46 ` Pekka Enberg
2008-10-07 13:25 ` Christoph Lameter
2008-10-05 2:28 ` [PATCH next 3/3] slub defrag: slabinfo help trivia Hugh Dickins
2008-10-06 7:40 ` Pekka Enberg
2008-10-06 7:53 ` [PATCH next 1/3] slub defrag: unpin writeback pages Pekka Enberg
2008-10-07 13:24 ` Christoph Lameter
2008-10-07 15:34 ` Hugh Dickins
2008-10-07 15:41 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB8314.1030701@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.