From: "H. Peter Anvin" <hpa@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/3] Provide rdtscll() asm/msr.h for user space
Date: Tue, 07 Oct 2008 16:25:00 -0700 [thread overview]
Message-ID: <48EBEFCC.4090302@kernel.org> (raw)
In-Reply-To: <20081007231149.GT20740@one.firstfloor.org>
Andi Kleen wrote:
>
>> I would suggest writing a <sys/tsc.h> header file and submitting to the
>> glibc people, instead, or perhaps even better, start a libarch/libx86 tree.
>
> That wouldn't work on old kernels. asm/msr.h has been the traditional
> interface for this and rdtsc has worked forever (at least dating back to 2.0)
> rdtscll is a bit newer, but still in Linux terms ancient (2.4)
>
It would definitely work on older kernels. Just don't stomp on the
kernel's namespace and you can do whatever you want.
> Also in my experience distributions are extremly slow at keeping up
> with glibc, so even if this was added to glibc it would be probably
> years before it would be actually usable :/ And I see about zero
> point in changing a perfectly fine include name breaking everything old.
So ship the include file with your utility. Hardly a big deal. But
yes, that's part of why I'm mentioning the idea of putting it in a
separate library, which can also house other low-level constructs.
> Anyways if you insist I can probably deal without
> but I (and likely others) would think something nasty about you every time
> I have to cut'n'paste that code again. Do you really want to risk that? @)
If you're really incapable of maintaining a single user-mode header file
with a handful of one-liners in a sane way, then definitely.
-hpa
next prev parent reply other threads:[~2008-10-07 23:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 11:43 [PATCH] [1/3] Provide rdtscll() asm/msr.h for user space Andi Kleen
2008-10-07 11:43 ` [PATCH] [2/3] Use the fancy DECLARE_EAX_EDX macros for rdtscp too Andi Kleen
2008-10-07 11:43 ` [PATCH] [3/3] Remove unused EAX_EDX_ARGS Andi Kleen
2008-10-07 21:32 ` [PATCH] [1/3] Provide rdtscll() asm/msr.h for user space H. Peter Anvin
2008-10-07 23:11 ` Andi Kleen
2008-10-07 23:25 ` H. Peter Anvin [this message]
2008-10-07 23:37 ` Andi Kleen
2008-10-07 23:45 ` H. Peter Anvin
2008-10-07 23:42 ` [PATCH] [1/3] Provide rdtscll() asm/msr.h for user space II Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EBEFCC.4090302@kernel.org \
--to=hpa@kernel.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.