From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Wed, 08 Oct 2008 11:02:06 +0000 Subject: Re: [PATCH 04/08]kvm: Split arch/x86/kvm/irq.c to two parts. Message-Id: <48EC932E.1030000@redhat.com> List-Id: References: <42DFA526FC41B1429CE7279EF83C6BDC01ABCA37@pdsmsx415.ccr.corp.intel.com> In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01ABCA37@pdsmsx415.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Zhang, Xiantao wrote: > From 720dab659e581adba3a7846db6d2f612ffcd83a0 Mon Sep 17 00:00:00 2001 > From: Xiantao Zhang > Date: Mon, 6 Oct 2008 13:48:45 +0800 > Subject: [PATCH] kvm: Split arch/x86/kvm/irq.c to two parts. > > Moving irq ack notification logic as common, and make > it shared with ia64 side. > > +/* This should be called with the kvm->lock mutex held */ > +void kvm_set_irq(struct kvm *kvm, int irq, int level) > +{ > + /* Not possible to detect if the guest uses the PIC or the > + * IOAPIC. So set the bit in both. The guest will ignore > + * writes to the unused one. > + */ > + kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level); > +#ifdef X86 > + kvm_pic_set_irq(pic_irqchip(kvm), irq, level); > +#endif > +} > + > This needs to be CONFIG_X86, not X86. As is, Windows doesn't even boot. Fixing it causes compile errors for missing declarations and pic_irqchip(). Please fix ASAP and test much more carefully. Meanwhile I am reverting the patchset. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 04/08]kvm: Split arch/x86/kvm/irq.c to two parts. Date: Wed, 08 Oct 2008 13:02:06 +0200 Message-ID: <48EC932E.1030000@redhat.com> References: <42DFA526FC41B1429CE7279EF83C6BDC01ABCA37@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org To: "Zhang, Xiantao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56050 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbYJHLCH (ORCPT ); Wed, 8 Oct 2008 07:02:07 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01ABCA37@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > From 720dab659e581adba3a7846db6d2f612ffcd83a0 Mon Sep 17 00:00:00 2001 > From: Xiantao Zhang > Date: Mon, 6 Oct 2008 13:48:45 +0800 > Subject: [PATCH] kvm: Split arch/x86/kvm/irq.c to two parts. > > Moving irq ack notification logic as common, and make > it shared with ia64 side. > > +/* This should be called with the kvm->lock mutex held */ > +void kvm_set_irq(struct kvm *kvm, int irq, int level) > +{ > + /* Not possible to detect if the guest uses the PIC or the > + * IOAPIC. So set the bit in both. The guest will ignore > + * writes to the unused one. > + */ > + kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level); > +#ifdef X86 > + kvm_pic_set_irq(pic_irqchip(kvm), irq, level); > +#endif > +} > + > This needs to be CONFIG_X86, not X86. As is, Windows doesn't even boot. Fixing it causes compile errors for missing declarations and pic_irqchip(). Please fix ASAP and test much more carefully. Meanwhile I am reverting the patchset. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.