Re: [PATCH 1/3] kexec/kdump: read crash memory ranges from drconf memory

[Chandru <chandru@in.ibm.com>]

Simon Horman wrote:

> On Wed, Oct 08, 2008 at 12:40:57PM +1100, Simon Horman wrote:
>
> [snip]	
>
>   
>>> --- kexec-tools-orig/kexec/arch/ppc64/crashdump-ppc64.h	2008-09-24 
>>> 14:46:55.000000000 +0530
>>> +++ kexec-tools/kexec/arch/ppc64/crashdump-ppc64.h	2008-09-16 
>>> 19:18:57.000000000 +0530
>>> @@ -28,4 +28,7 @@ extern uint64_t crash_size;
>>>  extern unsigned int rtas_base;
>>>  extern unsigned int rtas_size;
>>>  
>>> +uint64_t lmb_size;
>>> +unsigned int num_of_lmbs;
>>> +
>>>       
>> I am a little confused about why these variables need to be global
>> as they only seem to be used inside get_crash_memory_ranges().
>> I am also a little confused about how they are initialised.
>>     
>
> Ok, looking further I see that these are also used
> by code introduced in patch 2 and are initialised in
> code added by patch 3. It would be nicer have them
> intitalised in this patch as I'm not sure that
> the code will work sensibly with just this patch
> or just this patch and patch 2 applied, which may
> be important for bisection in the future.
>
>   
Hello Simon,

Thanks for reviewing the patch. The reference to lmb_size and 
num_of_lmbs exists in all the three patches. Either all these patches 
have to be applied together or they will have to be removed completely 
if we were to bisect the code. We could have one big patch from all 
these patches instead of three. Pls let me know if that makes it easier 
to locate any problems in the future. Also the 'static' scope on cstart 
and cend and memory_ranges could be removed in crashdump-ppc64.c. They 
can be let to have a program scope. Pls let me know, I will send the 
same patch removing these scopes.

Thanks,
Chandru


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec