From: Dave Jiang <djiang@mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: norsk5@yahoo.com, bluesmoke-devel@lists.sourceforge.net,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] edac: mpc85xx: Add support for new compatible types, mpc8536 and mpc8560
Date: Wed, 08 Oct 2008 09:18:35 -0700 [thread overview]
Message-ID: <48ECDD5B.1070507@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0810080721120.4673@blarg.am.freescale.net>
Acked-by: Dave Jiang <djiang@mvista.com>
Kumar Gala wrote:
> All other compatibles that are uniquely identifying the processor use
> a prefix of the form fsl,mpc85...'. We add support for it so we
> can deprecate the older 'fsl,85...' that was inproperly used here.
>
> Additionally added mpc8536 & mpc8560 to the compatible lists.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>
> This patch is based on Nate's 8572 patch.
>
> drivers/edac/mpc85xx_edac.c | 74 ++++++++++++++++++------------------------
> 1 files changed, 32 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 63bdc47..184799a 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -630,27 +630,22 @@ static int mpc85xx_l2_err_remove(struct of_device *op)
> }
>
> static struct of_device_id mpc85xx_l2_err_of_match[] = {
> - {
> - .compatible = "fsl,8540-l2-cache-controller",
> - },
> - {
> - .compatible = "fsl,8541-l2-cache-controller",
> - },
> - {
> - .compatible = "fsl,8544-l2-cache-controller",
> - },
> - {
> - .compatible = "fsl,8548-l2-cache-controller",
> - },
> - {
> - .compatible = "fsl,8555-l2-cache-controller",
> - },
> - {
> - .compatible = "fsl,8568-l2-cache-controller",
> - },
> - {
> - .compatible = "fsl,mpc8572-l2-cache-controller",
> - },
> +/* deprecate the fsl,85.. forms in the future, 2.6.30? */
> + { .compatible = "fsl,8540-l2-cache-controller", },
> + { .compatible = "fsl,8541-l2-cache-controller", },
> + { .compatible = "fsl,8544-l2-cache-controller", },
> + { .compatible = "fsl,8548-l2-cache-controller", },
> + { .compatible = "fsl,8555-l2-cache-controller", },
> + { .compatible = "fsl,8568-l2-cache-controller", },
> + { .compatible = "fsl,mpc8536-l2-cache-controller", },
> + { .compatible = "fsl,mpc8540-l2-cache-controller", },
> + { .compatible = "fsl,mpc8541-l2-cache-controller", },
> + { .compatible = "fsl,mpc8544-l2-cache-controller", },
> + { .compatible = "fsl,mpc8548-l2-cache-controller", },
> + { .compatible = "fsl,mpc8555-l2-cache-controller", },
> + { .compatible = "fsl,mpc8560-l2-cache-controller", },
> + { .compatible = "fsl,mpc8568-l2-cache-controller", },
> + { .compatible = "fsl,mpc8572-l2-cache-controller", },
> {},
> };
>
> @@ -967,27 +962,22 @@ static int mpc85xx_mc_err_remove(struct of_device *op)
> }
>
> static struct of_device_id mpc85xx_mc_err_of_match[] = {
> - {
> - .compatible = "fsl,8540-memory-controller",
> - },
> - {
> - .compatible = "fsl,8541-memory-controller",
> - },
> - {
> - .compatible = "fsl,8544-memory-controller",
> - },
> - {
> - .compatible = "fsl,8548-memory-controller",
> - },
> - {
> - .compatible = "fsl,8555-memory-controller",
> - },
> - {
> - .compatible = "fsl,8568-memory-controller",
> - },
> - {
> - .compatible = "fsl,mpc8572-memory-controller",
> - },
> +/* deprecate the fsl,85.. forms in the future, 2.6.30? */
> + { .compatible = "fsl,8540-memory-controller", },
> + { .compatible = "fsl,8541-memory-controller", },
> + { .compatible = "fsl,8544-memory-controller", },
> + { .compatible = "fsl,8548-memory-controller", },
> + { .compatible = "fsl,8555-memory-controller", },
> + { .compatible = "fsl,8568-memory-controller", },
> + { .compatible = "fsl,mpc8536-memory-controller", },
> + { .compatible = "fsl,mpc8540-memory-controller", },
> + { .compatible = "fsl,mpc8541-memory-controller", },
> + { .compatible = "fsl,mpc8544-memory-controller", },
> + { .compatible = "fsl,mpc8548-memory-controller", },
> + { .compatible = "fsl,mpc8555-memory-controller", },
> + { .compatible = "fsl,mpc8560-memory-controller", },
> + { .compatible = "fsl,mpc8568-memory-controller", },
> + { .compatible = "fsl,mpc8572-memory-controller", },
> {},
> };
>
--
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
prev parent reply other threads:[~2008-10-08 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 12:22 [PATCH] edac: mpc85xx: Add support for new compatible types, mpc8536 and mpc8560 Kumar Gala
2008-10-08 16:18 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ECDD5B.1070507@mvista.com \
--to=djiang@mvista.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=norsk5@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.