All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-fbdev-devel@lists.sourceforge.net,
	akpm <akpm@linux-foundation.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Subject: [PATCH] framebuffer: fix carminefb section mismatch
Date: Wed, 08 Oct 2008 14:20:49 -0700	[thread overview]
Message-ID: <48ED2431.40609@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle.com>

Could fix a dangerous problem since
	info->fix = carminefb_fix;
and info->fix can be used at any time later (in carmine_set_par()).

WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix
The function alloc_carmine_fb() references
the variable __devinitdata carminefb_fix.
This is often because alloc_carmine_fb lacks a __devinitdata 
annotation or the annotation of carminefb_fix is wrong.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Sebastian Siewior <bigeasy@linutronix.de>
---
 drivers/video/carminefb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lin2627-r9g1-sections.orig/drivers/video/carminefb.c
+++ lin2627-r9g1-sections/drivers/video/carminefb.c
@@ -76,7 +76,7 @@ struct carmine_fb {
 	u32 pseudo_palette[16];
 };
 
-static struct fb_fix_screeninfo carminefb_fix __devinitdata = {
+static struct fb_fix_screeninfo carminefb_fix = {
 	.id = "Carmine",
 	.type = FB_TYPE_PACKED_PIXELS,
 	.visual = FB_VISUAL_TRUECOLOR,

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

             reply	other threads:[~2008-10-08 21:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08 21:20 Randy Dunlap [this message]
2008-10-09  7:29 ` [PATCH] framebuffer: fix carminefb section mismatch Geert Uytterhoeven
2008-10-09 15:10   ` Randy Dunlap
2008-10-10 20:25     ` [PATCH v2] " Randy Dunlap
2008-10-13  8:41       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ED2431.40609@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.