From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@novell.com>
Subject: Re: [PATCH] fix 3.3-testing c/s 18434
Date: Thu, 09 Oct 2008 16:02:49 -0600
Message-ID: <48EE7F89.7030600@novell.com>
References: <C512B529.1DFDB%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------060604030804000909090708"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C512B529.1DFDB%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------060604030804000909090708
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Keir Fraser wrote:
> On 8/10/08 18:47, "Jim Fehlig" <jfehlig@novell.com> wrote:
>
>   
>> c/s 18434 in xen-3.3-testing has a hunk that changes gatherDom() to
>> _gatherDom() in tools/python/xen/xend/image.py.  There is no such
>> method, thus simple "xm list" fails
>>
>> jfehlig4: # xm li
>> Error: _gatherDom
>> Usage: xm list [options] [Domain, ...]
>> ..
>>
>> Trivial fix attached.  BTW, I don't see this patch in xen-unstable.  Why
>> is this only in xen3.3-testing?
>>     
>
> It is in xen-unstable, as c/s 18564 (which is part of
> xen-3.3-testing:18434).

Missed that, sorry.

I've also found that this c/s causes /local/domain/0/backend/{vkbd, vfb,
console} paths to leak :(.  Patch attached.

Thanks,
Jim

    Signed-off-by: Jim Fehlig <jfehlig@novell.com>



--------------060604030804000909090708
Content-Type: text/x-patch;
 name="xenstore-leak.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="xenstore-leak.patch"

diff -r 8cc28137805d tools/python/xen/xend/server/DevController.py
--- a/tools/python/xen/xend/server/DevController.py	Thu Oct 09 11:00:51 2008 +0100
+++ b/tools/python/xen/xend/server/DevController.py	Thu Oct 09 16:00:08 2008 -0600
@@ -257,7 +257,7 @@ class DevController:
 
         if force:
             frontpath = self.frontendPath(dev)
-            backpath = self.readVm(devid, "backend")
+            backpath = xstransact.Read(frontpath, "backend")
             if backpath:
                 xstransact.Remove(backpath)
             xstransact.Remove(frontpath)

--------------060604030804000909090708
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------060604030804000909090708--