From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Krzysztof Oledzki <ole@ans.pl>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH][libnetfilter_conntrack] add support for explicit helper assignment
Date: Fri, 10 Oct 2008 15:02:07 +0200 [thread overview]
Message-ID: <48EF524F.7070705@trash.net> (raw)
In-Reply-To: <48EE386A.1010602@netfilter.org>
Pablo Neira Ayuso wrote:
> Krzysztof Oledzki wrote:
>> Any chances to make it more frendly to new helpers and compatible with
>> out-of-tree helpers by registering a name directly from a helper and
>> using it? We may for example introduce something like /proc/net/nf_helpers.
>
> We may directly set the name of the helper using the string that
> identifies it instead of this id. However, this means more memory
> consumption but more flexibility. I have another patch here that uses
> strings to do so. The problem is that helpers doesn't have a limitation
> in the name length and I don't like the idea of having a field
> "helper_name" with variable length inside the nf_conntrack object. We
> could make some reasonable assumptions, like considering that the helper
> name would not be larger than 32 bytes.
Limiting the name makes sense. The helper match can only match
on I think 16 bytes, and that seems big enough.
next prev parent reply other threads:[~2008-10-10 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 10:35 [PATCH][libnetfilter_conntrack] add support for explicit helper assignment Pablo Neira Ayuso
2008-10-09 16:26 ` Krzysztof Oledzki
2008-10-09 16:59 ` Pablo Neira Ayuso
2008-10-09 17:15 ` Krzysztof Oledzki
2008-10-09 20:30 ` Jan Engelhardt
2008-10-10 13:02 ` Patrick McHardy [this message]
2008-10-11 12:44 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EF524F.7070705@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.