From: "H. Peter Anvin" <hpa@zytor.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, Anders Kaseorg <andersk@MIT.EDU>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly
Date: Fri, 10 Oct 2008 09:12:23 -0700 [thread overview]
Message-ID: <48EF7EE7.6040409@zytor.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0810100927110.26408@gandalf.stny.rr.com>
Steven Rostedt wrote:
> On Fri, 10 Oct 2008, Ingo Molnar wrote:
>
>> * Anders Kaseorg <andersk@MIT.EDU> wrote:
>>
>>> Commit 4c3dc21b136f8cb4b72afee16c3ba7e961656c0b in tip introduced the
>>> 5-byte NOP ftrace_test_p6nop:
>>> jmp . + 5
>>> .byte 0x00, 0x00, 0x00
>>> This is not friendly to disassemblers because an odd number of 0x00s
>>> ends in the middle of an instruction boundary. This changes the 0x00s
>>> to 1-byte NOPs (0x90).
>>>
>>> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
>> applied to tip/tracing/ftrace, good spotting Anders!
>>
>> Steve, any objections?
>
> Nope, it's fine with me.
>
> Acked-by: Steven Rostedt <srostedt@redhat.com>
>
The (semi-)amusing thing is that it should never, ever, get there.
66 66 66 66 90 is used over this, which should always work.
-hpa
next prev parent reply other threads:[~2008-10-10 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 2:19 [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly Anders Kaseorg
2008-10-10 8:54 ` Ingo Molnar
2008-10-10 13:27 ` Steven Rostedt
2008-10-10 16:12 ` H. Peter Anvin [this message]
2008-10-10 16:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EF7EE7.6040409@zytor.com \
--to=hpa@zytor.com \
--cc=andersk@MIT.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.